Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 433073003: Fix memory leak in NotificationProviderApiTest.Events. (Closed)

Created:
6 years, 4 months ago by pneubeck (no reviews)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix memory leak in NotificationProviderApiTest.Events. This new test had a memory leak as reported by Linux ASan LSan: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/4540/steps/browser_tests/logs/Events TBR=kalman@chromium.org, liyanhou@chromium.org BUG=397197 NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287170

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/extensions/api/notification_provider/notification_provider_apitest.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
pneubeck (no reviews)
The CQ bit was checked by pneubeck@chromium.org
6 years, 4 months ago (2014-08-02 07:09:28 UTC) #1
pneubeck (no reviews)
The CQ bit was unchecked by pneubeck@chromium.org
6 years, 4 months ago (2014-08-02 07:09:35 UTC) #2
pneubeck (no reviews)
The CQ bit was checked by pneubeck@chromium.org
6 years, 4 months ago (2014-08-02 07:21:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/433073003/20001
6 years, 4 months ago (2014-08-02 07:23:28 UTC) #4
pneubeck (no reviews)
The CQ bit was unchecked by pneubeck@chromium.org
6 years, 4 months ago (2014-08-02 07:26:39 UTC) #5
pneubeck (no reviews)
The CQ bit was checked by pneubeck@chromium.org
6 years, 4 months ago (2014-08-02 07:26:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/433073003/20001
6 years, 4 months ago (2014-08-02 07:28:50 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-02 07:30:35 UTC) #8
Message was sent while issue was closed.
Change committed as 287170

Powered by Google App Engine
This is Rietveld 408576698