Issue 433063002: Memory improvements to render_pdfs; better DM pool size defaults

Issue 433063002: Memory improvements to render_pdfs; better DM pool size defaults (Closed)

Created:
6 years, 4 months ago by hal.canary

Modified:
5 years, 8 months ago

Reviewers:
djsollen, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Memory improvements to render_pdfs; better DM pool size defaults Make SK_DEFAULT_GLOBAL_DISCARDABLE_MEMORY_POOL_SIZE equal to skia_resource_cache_mb_limit, if that value is >0 (true for some low-memory Android devices). render_pdfs test program uses lazy decoding (and the discardable memory pool). BUG=skia:2743 Committed: https://skia.googlesource.com/skia/+/66058b614d9c8cb63c24b1c779dd1a9a80752217

Patch Set 1 #

Patch Set 2 : remove extranious include #

Patch Set 3 #

Patch Set 4 : fix tools.gyp #

Patch Set 5 : default DM_POOL_SIZE smalle ron android #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -2 lines)			Patch
M	gyp/common_conditions.gypi	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	gyp/tools.gyp	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/lazy/SkDiscardableMemoryPool.h	View	1 2 3 4	1 chunk	+13 lines, -1 line	0 comments	Download
M	tools/render_pdfs_main.cpp	View	1 2 3	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/433063002/20001

6 years, 4 months ago (2014-08-01 15:38:08 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/433063002/60001

6 years, 4 months ago (2014-08-01 16:11:19 UTC) #6

commit-bot: I haz the power

Change committed as 66058b614d9c8cb63c24b1c779dd1a9a80752217

6 years, 4 months ago (2014-08-01 16:25:16 UTC) #7

hal.canary

6 years, 4 months ago (2014-08-01 18:53:43 UTC) #8

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/418173012/ by halcanary@google.com.

The reason for reverting is: breaking android tests.

Expand Messages | Collapse Messages