Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 433001: Don't select a default entry in the password autofill popup (Closed)

Created:
11 years, 1 month ago by jcampan
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, darin (slow to review)
Visibility:
Public.

Description

Don't select a default entry in the password autofill popup. It is annoying as pressing tab/enter after modifying the text field value would select the popup default entry again overriding your change. BUG=24550 TEST=Trigger the password autofill entry. Modify the suggested login name, press tab. The login you entered should be preserved.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M webkit/glue/webpasswordautocompletelistener_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jcampan
11 years, 1 month ago (2009-11-22 09:25:57 UTC) #1
tim (not reviewing)
On 2009/11/22 09:25:57, jcampan wrote: > Does this basically mean "don't inline autocomplete"? It's okay ...
11 years, 1 month ago (2009-11-23 18:10:01 UTC) #2
tim (not reviewing)
11 years, 1 month ago (2009-11-23 18:32:55 UTC) #3
LGTM (assuming the test passes locally :) )

Powered by Google App Engine
This is Rietveld 408576698