Chromium Code Reviews| Index: content/renderer/media/media_stream_video_track_unittest.cc |
| diff --git a/content/renderer/media/media_stream_video_track_unittest.cc b/content/renderer/media/media_stream_video_track_unittest.cc |
| index 9b281a67d1553d985a436e261299956e1a96c2cf..91ec3f401afe9861ec4d4354d875b3068dc2a782 100644 |
| --- a/content/renderer/media/media_stream_video_track_unittest.cc |
| +++ b/content/renderer/media/media_stream_video_track_unittest.cc |
| @@ -18,6 +18,9 @@ |
| namespace content { |
| +const uint8 kBlackValue = 0x00; |
| +const uint8 kColorValue = 0xFF; |
|
tommi (sloooow) - chröme
2014/08/05 09:50:46
nit: maybe we should pick a different, harder to g
perkj_chrome
2014/08/06 12:32:22
Done.
|
| + |
| ACTION_P(RunClosure, closure) { |
| closure.Run(); |
| } |
| @@ -43,9 +46,10 @@ class MediaStreamVideoTrackTest : public ::testing::Test { |
| EXPECT_CALL(*sink, OnVideoFrame()).WillOnce( |
| RunClosure(quit_closure)); |
| scoped_refptr<media::VideoFrame> frame = |
| - media::VideoFrame::CreateBlackFrame( |
| + media::VideoFrame::CreateColorFrame( |
| gfx::Size(MediaStreamVideoSource::kDefaultWidth, |
| - MediaStreamVideoSource::kDefaultHeight)); |
| + MediaStreamVideoSource::kDefaultHeight), |
| + kColorValue, kColorValue, kColorValue, base::TimeDelta()); |
| mock_source()->DeliverVideoFrame(frame); |
| run_loop.Run(); |
| } |
| @@ -163,24 +167,20 @@ TEST_F(MediaStreamVideoTrackTest, SetEnabled) { |
| DeliverVideoFrameAndWaitForRenderer(&sink); |
| EXPECT_EQ(1, sink.number_of_frames()); |
| + EXPECT_EQ(kColorValue, *sink.last_frame()->data(media::VideoFrame::kYPlane)); |
| video_track->SetEnabled(false); |
| EXPECT_FALSE(sink.enabled()); |
| - scoped_refptr<media::VideoFrame> frame = |
| - media::VideoFrame::CreateBlackFrame( |
| - gfx::Size(MediaStreamVideoSource::kDefaultWidth, |
| - MediaStreamVideoSource::kDefaultHeight)); |
| - mock_source()->DeliverVideoFrame(frame); |
| - // Wait for the IO thread to complete delivering frames. |
| - io_message_loop()->RunUntilIdle(); |
| - EXPECT_EQ(1, sink.number_of_frames()); |
| + DeliverVideoFrameAndWaitForRenderer(&sink); |
| + EXPECT_EQ(2, sink.number_of_frames()); |
| + EXPECT_EQ(kBlackValue, *sink.last_frame()->data(media::VideoFrame::kYPlane)); |
| video_track->SetEnabled(true); |
| EXPECT_TRUE(sink.enabled()); |
| - mock_source()->DeliverVideoFrame(frame); |
| DeliverVideoFrameAndWaitForRenderer(&sink); |
| - EXPECT_EQ(2, sink.number_of_frames()); |
| + EXPECT_EQ(3, sink.number_of_frames()); |
| + EXPECT_EQ(kColorValue, *sink.last_frame()->data(media::VideoFrame::kYPlane)); |
| MediaStreamVideoSink::RemoveFromVideoTrack(&sink, track); |
| } |