Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 432863002: Only activate SSE2 by default on ia32 (Closed)

Created:
6 years, 4 months ago by danno
Modified:
6 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Only activate SSE2 by default on ia32 R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22779

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/toolchain.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danno
PTAL
6 years, 4 months ago (2014-07-31 16:50:41 UTC) #1
Jakob Kummerow
LGTM with comment. https://codereview.chromium.org/432863002/diff/1/build/toolchain.gypi File build/toolchain.gypi (right): https://codereview.chromium.org/432863002/diff/1/build/toolchain.gypi#newcode464 build/toolchain.gypi:464: ['OS=="win" and target_arch=="ia32"', { better use ...
6 years, 4 months ago (2014-07-31 16:52:43 UTC) #2
danno
6 years, 4 months ago (2014-08-01 08:00:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22779 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698