Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 432833002: Prevent repeated taps from resetting insertion handle position (Closed)

Created:
6 years, 4 months ago by jdduke (slow)
Modified:
6 years, 4 months ago
Reviewers:
CC:
chromium-reviews, darin-cc_chromium.org, jdduke+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Prevent repeated taps from resetting insertion handle position Repeated longpress and tap gestures were resetting the cached handle positions in anticipation of receiving updated values from the renderer. However, if the gesture failed to change the selection position, no update was received, and subsequent taps on the handle would improperly position the paste popup at the reset position. Fix this by avoiding cached position resets when the insertion or selection is already active. BUG=399222

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -10 lines) Patch
M content/browser/renderer_host/input/touch_selection_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_selection_controller.cc View 6 chunks +10 lines, -9 lines 0 comments Download
M content/browser/renderer_host/input/touch_selection_controller_unittest.cc View 1 chunk +43 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698