Issue 43273005: Remove git_filter=True from git cache_dir commands.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 43273005: Remove git_filter=True from git cache_dir commands. (Closed)

Created:
7 years, 1 month ago by agable

Modified:
7 years, 1 month ago

Reviewers:
iannucci, M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Remove git_filter=True from git cache_dir commands. This helps prevent timeout when checking out large repositories (like blink) using the git cache_dir. R=iannucci@chromium.org, maruel@chromium.org BUG=295119 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=231111

Patch Set 1 #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -7 lines)			Patch
	M	gclient_scm.py	View		4 chunks	+5 lines, -7 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

iannucci

lgtm https://codereview.chromium.org/43273005/diff/1/gclient_scm.py File gclient_scm.py (right): https://codereview.chromium.org/43273005/diff/1/gclient_scm.py#newcode1040 gclient_scm.py:1040: if git_filter: I'd combine this, but I'm pretty ...

7 years, 1 month ago (2013-10-25 18:54:42 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agable@chromium.org/43273005/1

7 years, 1 month ago (2013-10-25 20:52:49 UTC) #3

Message was sent while issue was closed.

Change committed as 231111

Expand Messages | Collapse Messages