src/IceOperand.h - Issue 432613002: Subzero: Fix some issues related to legalization and undef handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceOperand.h

Issue 432613002: Subzero: Fix some issues related to legalization and undef handling. (Closed) Base URL: https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master

Patch Set: Address comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceOperand.h

diff --git a/src/IceOperand.h b/src/IceOperand.h

index bbd6688fe5cd684c436c5bf1abc31eda095b5ae3..73e51e5138387d8c1cbcf76159db5d5bf75c894a 100644

--- a/src/IceOperand.h

+++ b/src/IceOperand.h

@@ -217,10 +217,8 @@ public:

}

using Constant::emit;

- virtual void emit(GlobalContext *Ctx) const {

- Ostream &Str = Ctx->getStrEmit();

- Str << "undef";

- }

+ // The target needs to implement this.

+ virtual void emit(GlobalContext *Ctx) const;

using Constant::dump;

virtual void dump(GlobalContext *Ctx) const {

« no previous file with comments | « no previous file | src/IceTargetLoweringX8632.cpp » ('j') | no next file with comments »