Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1955)

Unified Diff: content/child/socket_stream_dispatcher.cc

Issue 432553003: Remove redundant mapping of net errors to strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Response to comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/android/org_chromium_net_UrlRequest.cc ('k') | device/bluetooth/bluetooth_socket_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/socket_stream_dispatcher.cc
diff --git a/content/child/socket_stream_dispatcher.cc b/content/child/socket_stream_dispatcher.cc
index 017a116466af111f4547056984bd2ea8e8ca3dc8..3a520d286d765ad7aae7bdbd33f5e59e78f95a52 100644
--- a/content/child/socket_stream_dispatcher.cc
+++ b/content/child/socket_stream_dispatcher.cc
@@ -4,6 +4,7 @@
#include "content/child/socket_stream_dispatcher.h"
+#include <string>
#include <vector>
#include "base/bind.h"
@@ -46,7 +47,7 @@ class IPCWebSocketStreamHandleBridge : public WebSocketStreamHandleBridge {
void OnSentData(int amount_sent);
void OnReceivedData(const std::vector<char>& data);
void OnClosed();
- void OnFailed(int error_code, const char* error_msg);
+ void OnFailed(int error_code, const std::string& error_msg);
private:
virtual ~IPCWebSocketStreamHandleBridge();
@@ -163,7 +164,7 @@ void IPCWebSocketStreamHandleBridge::OnClosed() {
}
void IPCWebSocketStreamHandleBridge::OnFailed(int error_code,
- const char* error_msg) {
+ const std::string& error_msg) {
DVLOG(1) << "Bridge #" << socket_id_ << " OnFailed (error_code=" << error_code
<< ")";
if (delegate_)
« no previous file with comments | « components/cronet/android/org_chromium_net_UrlRequest.cc ('k') | device/bluetooth/bluetooth_socket_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698