Remove redundant mapping of net errors to strings.

net/base/net_errors.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_NET_ERRORS_H__
 #define NET_BASE_NET_ERRORS_H__
 
+#include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/files/file.h"
 #include "net/base/net_export.h"
 
 namespace net {
 
 // Error domain of the net module's error codes.
 NET_EXPORT extern const char kErrorDomain[];
 
 // Error values are negative.
 enum Error {
   // No error.
   OK = 0,
 
 #define NET_ERROR(label, value) ERR_ ## label = value,
 #include "net/base/net_error_list.h"
 #undef NET_ERROR
 
   // The value of the first certificate error code.
   ERR_CERT_BEGIN = ERR_CERT_COMMON_NAME_INVALID,
 };
 
+// Same as above, but leaves off the leading "net::".

[eroman, 2014/08/05 22:54:51]

"Same as below", or move this down ;)

[mmenke, 2014/08/06 16:40:56]

Moved it down (And its definition as well), "same as below" just seems weird.

+NET_EXPORT std::string ErrorToShortString(int error);
+
 // Returns a textual representation of the error code for logging purposes.
-NET_EXPORT const char* ErrorToString(int error);
+NET_EXPORT std::string ErrorToString(int error);
 
 // Returns true if |error| is a certificate error code.
-inline bool IsCertificateError(int error) {
-  // Certificate errors are negative integers from net::ERR_CERT_BEGIN
-  // (inclusive) to net::ERR_CERT_END (exclusive) in *decreasing* order.
-  // ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN is currently an exception to this
-  // rule.
-  return (error <= ERR_CERT_BEGIN && error > ERR_CERT_END) ||
-         (error == ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN);
-}
+NET_EXPORT bool IsCertificateError(int error);
 
 // Map system error code to Error.
 NET_EXPORT Error MapSystemError(int os_error);
 
 // Returns a list of all the possible net error codes (not counting OK). This
 // is intended for use with UMA histograms that are reporting the result of
 // an action that is represented as a net error code.
 //
 // Note that the error codes are all positive (since histograms expect positive
 // sample values). Also note that a guard bucket is created after any valid
 // error code that is not followed immediately by a valid error code.
 NET_EXPORT std::vector<int> GetAllErrorCodesForUma();
 
 // A convenient function to translate file error to net error code.
 NET_EXPORT Error FileErrorToNetError(base::File::Error file_error);
 
 }  // namespace net
 
 #endif  // NET_BASE_NET_ERRORS_H__