tools/telemetry/telemetry/page/record_wpr_unittest.py - Issue 432543003: Add usage message with available page_sets and benchmarks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/record_wpr_unittest.py

Issue 432543003: Add usage message with available page_sets and benchmarks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/core/discover.py ('K') | « tools/telemetry/telemetry/page/record_wpr.py ('k') | tools/telemetry/telemetry/test_runner.py » ('j') | tools/telemetry/telemetry/test_runner.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/page/record_wpr_unittest.py

diff --git a/tools/telemetry/telemetry/page/record_wpr_unittest.py b/tools/telemetry/telemetry/page/record_wpr_unittest.py

index a434fa9622837dd38f4f3f3a1743a36327237598..5a1710df5d07c07756f7989982b6642eb45b7e98 100644

--- a/tools/telemetry/telemetry/page/record_wpr_unittest.py

+++ b/tools/telemetry/telemetry/page/record_wpr_unittest.py

@@ -148,7 +148,7 @@ class RecordWprUnitTests(tab_test_case.TabTestCase):

flags = []

mock_page_set = MockPageSet(url=self._url)

wpr_recorder = record_wpr.WprRecorder(self._test_data_dir,

- mock_page_set, flags)

+ mock_page_set, 'run', flags)

results = wpr_recorder.CreateResults()

wpr_recorder.Record(results)

self.assertEqual(set(mock_page_set.pages), results.pages_that_succeeded)

@@ -157,7 +157,7 @@ class RecordWprUnitTests(tab_test_case.TabTestCase):

flags = ['--mock-benchmark-url', self._url]

mock_benchmark = MockBenchmark()

wpr_recorder = record_wpr.WprRecorder(self._test_data_dir, mock_benchmark,

- flags)

+ 'run', flags)

results = wpr_recorder.CreateResults()

wpr_recorder.Record(results)

self.assertEqual(set(mock_benchmark.mock_page_set.pages),

@@ -170,7 +170,7 @@ class RecordWprUnitTests(tab_test_case.TabTestCase):

'--mock-page-test-option',

]

wpr_recorder = record_wpr.WprRecorder(self._test_data_dir, MockBenchmark(),

- flags)

+ 'run', flags)

# page_runner command-line args

self.assertEquals(2, wpr_recorder.options.page_repeat)

# benchmark command-line args

@@ -183,7 +183,7 @@ class RecordWprUnitTests(tab_test_case.TabTestCase):

def testRecordingEnabled(self):

flags = ['--mock-benchmark-url', self._url]

wpr_recorder = record_wpr.WprRecorder(self._test_data_dir, MockBenchmark(),

- flags)

+ 'run', flags)

self.assertEqual(wpr_modes.WPR_RECORD,

wpr_recorder.options.browser_options.wpr_mode)