core/src/fxge/win32/fx_win32_device.cpp - Issue 432543002: Fix integer overflow when stretching bitmap for printing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxge/win32/fx_win32_device.cpp

Issue 432543002: Fix integer overflow when stretching bitmap for printing (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxge/win32/fx_win32_device.cpp

diff --git a/core/src/fxge/win32/fx_win32_device.cpp b/core/src/fxge/win32/fx_win32_device.cpp

index 154bbc407c873b132e1f52064ce55d463131978c..e0bede96833f564352bab3b7cd1684dcd9d6a706 100644

--- a/core/src/fxge/win32/fx_win32_device.cpp

+++ b/core/src/fxge/win32/fx_win32_device.cpp

@@ -531,7 +531,7 @@ FX_BOOL CGdiDeviceDriver::GDI_StretchDIBits(const CFX_DIBitmap* pBitmap1, int de

}

CFX_DIBitmap* pToStrechBitmap = pBitmap;

bool del = false;

- if (m_DeviceClass == FXDC_PRINTER && (pBitmap->GetWidth() * pBitmap->GetHeight() > abs(dest_width) * abs(dest_height))) {

+ if (m_DeviceClass == FXDC_PRINTER && (pBitmap->GetWidth()/abs(dest_width) > abs(dest_height)/pBitmap->GetHeight())) {

Vitaly Buka (NO REVIEWS) 2014/07/30 21:24:43 I guess better solution is just to cast to int64

pToStrechBitmap = pBitmap->StretchTo(dest_width, dest_height);

del = true;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »