Add initial pipeline for decompressors

Add initial pipeline for decompressors

Committed: https://skia.googlesource.com/skia/+/14a1df0bcd00734e6efbe4a21629fe95118815ef

Committed: https://skia.googlesource.com/skia/+/4ad76e35111585f4da662d54943f23792dd1e0ae

[krajcevski, 2014-07-31 14:50:35]

ping

[robertphillips, 2014-07-31 15:01:02]

https://codereview.chromium.org/432503002/diff/1/src/utils/SkTextureCompresso...
File src/utils/SkTextureCompressor.cpp (right):

https://codereview.chromium.org/432503002/diff/1/src/utils/SkTextureCompresso...
src/utils/SkTextureCompressor.cpp:22: 
Is there a better name then hardware?

https://codereview.chromium.org/432503002/diff/1/src/utils/SkTextureCompressor.h
File src/utils/SkTextureCompressor.h (right):

https://codereview.chromium.org/432503002/diff/1/src/utils/SkTextureCompresso...
src/utils/SkTextureCompressor.h:46: 
typo.

https://codereview.chromium.org/432503002/diff/1/src/utils/SkTextureCompresso...
File src/utils/SkTextureCompressor_R11EAC.cpp (right):

https://codereview.chromium.org/432503002/diff/1/src/utils/SkTextureCompresso...
src/utils/SkTextureCompressor_R11EAC.cpp:589: }
extra line ?

https://codereview.chromium.org/432503002/diff/1/tests/TextureCompressionTest...
File tests/TextureCompressionTest.cpp (right):

https://codereview.chromium.org/432503002/diff/1/tests/TextureCompressionTest...
tests/TextureCompressionTest.cpp:115: 
SkAutoMalloc ?

https://codereview.chromium.org/432503002/diff/1/tests/TextureCompressionTest...
tests/TextureCompressionTest.cpp:125: // ASTC is for RGBA data, and doesn't fit
the paradigm of this test.
// TODO: add ASTC decompression test (when ASTC decompression is added) ?

https://codereview.chromium.org/432503002/diff/1/tests/TextureCompressionTest...
tests/TextureCompressionTest.cpp:133: bool decompResult =
SkTextureCompressor::DecompressBufferFromFormat(
tab these guys over a bit (and maybe split across 2 lines) ?

[krajcevski, 2014-07-31 15:12:19]

https://codereview.chromium.org/432503002/diff/1/src/utils/SkTextureCompresso...
File src/utils/SkTextureCompressor.cpp (right):

https://codereview.chromium.org/432503002/diff/1/src/utils/SkTextureCompresso...
src/utils/SkTextureCompressor.cpp:22: 
On 2014/07/31 15:01:01, robertphillips wrote:
> Is there a better name then hardware?

Done.

https://codereview.chromium.org/432503002/diff/1/src/utils/SkTextureCompressor.h
File src/utils/SkTextureCompressor.h (right):

https://codereview.chromium.org/432503002/diff/1/src/utils/SkTextureCompresso...
src/utils/SkTextureCompressor.h:46: 
On 2014/07/31 15:01:01, robertphillips wrote:
> typo.

Done.

https://codereview.chromium.org/432503002/diff/1/src/utils/SkTextureCompresso...
File src/utils/SkTextureCompressor_R11EAC.cpp (right):

https://codereview.chromium.org/432503002/diff/1/src/utils/SkTextureCompresso...
src/utils/SkTextureCompressor_R11EAC.cpp:589: }
On 2014/07/31 15:01:02, robertphillips wrote:
> extra line ?

Done.

https://codereview.chromium.org/432503002/diff/1/tests/TextureCompressionTest...
File tests/TextureCompressionTest.cpp (right):

https://codereview.chromium.org/432503002/diff/1/tests/TextureCompressionTest...
tests/TextureCompressionTest.cpp:115: 
On 2014/07/31 15:01:02, robertphillips wrote:
> SkAutoMalloc ?

Done.

https://codereview.chromium.org/432503002/diff/1/tests/TextureCompressionTest...
tests/TextureCompressionTest.cpp:125: // ASTC is for RGBA data, and doesn't fit
the paradigm of this test.
On 2014/07/31 15:01:02, robertphillips wrote:
> // TODO: add ASTC decompression test (when ASTC decompression is added) ?

Done.

https://codereview.chromium.org/432503002/diff/1/tests/TextureCompressionTest...
tests/TextureCompressionTest.cpp:133: bool decompResult =
SkTextureCompressor::DecompressBufferFromFormat(
On 2014/07/31 15:01:02, robertphillips wrote:
> tab these guys over a bit (and maybe split across 2 lines) ?

Done.

[robertphillips, 2014-07-31 15:15:13]

lgtm + a comment suggestion & something to fix

https://codereview.chromium.org/432503002/diff/20001/src/utils/SkTextureCompr...
File src/utils/SkTextureCompressor.h (right):

https://codereview.chromium.org/432503002/diff/20001/src/utils/SkTextureCompr...
src/utils/SkTextureCompressor.h:81: // flag 'matchSpec' is true, then the actual
dimensions from the specification are returned.
// If it is false, then the ... ?

https://codereview.chromium.org/432503002/diff/20001/tests/TextureCompression...
File tests/TextureCompressionTest.cpp (right):

https://codereview.chromium.org/432503002/diff/20001/tests/TextureCompression...
tests/TextureCompressionTest.cpp:155: 
Don't think you want this here !

[krajcevski, 2014-07-31 15:28:54]

https://codereview.chromium.org/432503002/diff/20001/src/utils/SkTextureCompr...
File src/utils/SkTextureCompressor.h (right):

https://codereview.chromium.org/432503002/diff/20001/src/utils/SkTextureCompr...
src/utils/SkTextureCompressor.h:81: // flag 'matchSpec' is true, then the actual
dimensions from the specification are returned.
On 2014/07/31 15:15:13, robertphillips wrote:
> // If it is false, then the ... ?

Done.

https://codereview.chromium.org/432503002/diff/20001/tests/TextureCompression...
File tests/TextureCompressionTest.cpp (right):

https://codereview.chromium.org/432503002/diff/20001/tests/TextureCompression...
tests/TextureCompressionTest.cpp:155: 
On 2014/07/31 15:15:13, robertphillips wrote:
> Don't think you want this here !

Done.

[krajcevski, 2014-07-31 15:28:57]

The CQ bit was checked by krajcevski@google.com

[commit-bot: I haz the power, 2014-07-31 15:29:55]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/krajcevski@google.com/432503002/40001

[commit-bot: I haz the power, 2014-07-31 15:42:13]

Change committed as 14a1df0bcd00734e6efbe4a21629fe95118815ef

[mtklein, 2014-07-31 16:33:23]

A revert of this CL has been created in
https://codereview.chromium.org/425223006/ by mtklein@google.com.

The reason for reverting is: New test is crashing on Android.

http://108.170.220.21:10117/builders/Test-Android-Nexus10-MaliT604-Arm7-Debug...

http://108.170.220.21:10117/builders/Test-Android-Nexus4-Adreno320-Arm7-Debug....

[krajcevski, 2014-07-31 21:00:32]

The CQ bit was checked by krajcevski@google.com

[commit-bot: I haz the power, 2014-07-31 21:01:34]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/krajcevski@google.com/432503002/60001

[commit-bot: I haz the power, 2014-07-31 21:12:55]

Change committed as 4ad76e35111585f4da662d54943f23792dd1e0ae