Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 432433003: Fix build dependencies in src/extensions (Closed)

Created:
6 years, 4 months ago by James Cook
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, tfarina
Project:
chromium
Visibility:
Public.

Description

Fix build dependencies in src/extensions * lazy_background_task_queue_unittest.cc uses keyed_service/content directly so make dependency explicit. * I missed the GN build file when adding extensions_test.h/cc BUG=none TEST=compiles Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287471

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M extensions/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
James Cook
rockot, PTAL tfarina, FYI
6 years, 4 months ago (2014-08-04 21:19:15 UTC) #1
Ken Rockot(use gerrit already)
lgtm
6 years, 4 months ago (2014-08-04 21:30:29 UTC) #2
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 4 months ago (2014-08-04 21:44:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/432433003/1
6 years, 4 months ago (2014-08-04 21:45:39 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-04 23:10:32 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-04 23:16:51 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/37271)
6 years, 4 months ago (2014-08-04 23:16:51 UTC) #7
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 4 months ago (2014-08-04 23:36:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/432433003/1
6 years, 4 months ago (2014-08-04 23:38:34 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-05 01:38:40 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 01:45:31 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/37325)
6 years, 4 months ago (2014-08-05 01:45:32 UTC) #12
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 4 months ago (2014-08-05 01:51:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/432433003/1
6 years, 4 months ago (2014-08-05 01:53:51 UTC) #14
commit-bot: I haz the power
Change committed as 287471
6 years, 4 months ago (2014-08-05 06:40:01 UTC) #15
tfarina
6 years, 4 months ago (2014-08-05 14:11:20 UTC) #16
Message was sent while issue was closed.
lgtm

thanks

Powered by Google App Engine
This is Rietveld 408576698