Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 432323002: Add min-width/max-width/min-height/max-height to the fullscreen UA style sheet (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
Reviewers:
falken
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Project:
blink
Visibility:
Public.

Description

Add min-width/max-width/min-height/max-height to the fullscreen UA style sheet The spec has :fullscreen and obviously not :-webkit-full-screen, but this is the closest thing we can do before unprefixing. BUG=399543 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179580

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -2 lines) Patch
A LayoutTests/fullscreen/full-screen-min-max-width-height-iframe.html View 1 chunk +33 lines, -0 lines 0 comments Download
A LayoutTests/fullscreen/full-screen-min-max-width-height-iframe-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/fullscreen/full-screen-min-max-width-height-video.html View 1 chunk +33 lines, -0 lines 0 comments Download
A LayoutTests/fullscreen/full-screen-min-max-width-height-video-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/css/fullscreen.css View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 35 (0 generated)
philipj_slow
PTAL
6 years, 4 months ago (2014-08-01 08:58:43 UTC) #1
falken
On 2014/08/01 08:58:43, philipj wrote: > PTAL LGTM
6 years, 4 months ago (2014-08-05 04:50:14 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-08-05 05:25:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/432323002/1
6 years, 4 months ago (2014-08-05 05:26:05 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-05 06:06:29 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 06:43:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20769)
6 years, 4 months ago (2014-08-05 06:43:26 UTC) #7
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-08-05 07:35:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/432323002/1
6 years, 4 months ago (2014-08-05 07:35:51 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-05 08:35:44 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 09:31:49 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20826)
6 years, 4 months ago (2014-08-05 09:31:50 UTC) #12
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-08-05 09:42:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/432323002/1
6 years, 4 months ago (2014-08-05 09:43:33 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-05 10:29:43 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 11:31:47 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20866)
6 years, 4 months ago (2014-08-05 11:31:48 UTC) #17
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-08-05 12:03:09 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/432323002/1
6 years, 4 months ago (2014-08-05 12:05:04 UTC) #19
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-05 13:19:40 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 14:45:19 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20935)
6 years, 4 months ago (2014-08-05 14:45:20 UTC) #22
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-08-05 15:25:39 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/432323002/1
6 years, 4 months ago (2014-08-05 15:28:00 UTC) #24
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-05 20:28:16 UTC) #25
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 22:53:51 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/21116)
6 years, 4 months ago (2014-08-05 22:53:52 UTC) #27
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-08-06 06:01:13 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/432323002/1
6 years, 4 months ago (2014-08-06 06:02:13 UTC) #29
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-06 06:41:34 UTC) #30
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-06 07:27:05 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/21275)
6 years, 4 months ago (2014-08-06 07:27:06 UTC) #32
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-08-06 07:56:37 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/432323002/1
6 years, 4 months ago (2014-08-06 07:57:51 UTC) #34
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 08:38:14 UTC) #35
Message was sent while issue was closed.
Change committed as 179580

Powered by Google App Engine
This is Rietveld 408576698