Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 432243002: Revert 'gn: cross-platform exception disable' (Closed)

Created:
6 years, 4 months ago by scottmg
Modified:
6 years, 4 months ago
Reviewers:
Nico
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Revert 'gn: cross-platform exception disable' This reverts commit 4923e3cfbc2b617614858c427fa87a8c67aca784. Since exceptions are in the process of being removed, and the code currently isn't rollable into pdfium (for other reasons) I'm going to revert this for now, so that this CL doesn't become blocking-for-rolls if the other min/max problem is addressed. And, hopefully by the time I get back to this it won't be necessary anyway. BUG=pdfium:28, pdfium:31, chromium:354261 R=thakis@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/d4ca3b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -26 lines) Patch
M BUILD.gn View 13 chunks +39 lines, -26 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scottmg
6 years, 4 months ago (2014-08-01 00:22:22 UTC) #1
Nico
rslgtm
6 years, 4 months ago (2014-08-01 00:22:57 UTC) #2
scottmg
6 years, 4 months ago (2014-08-01 00:23:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as rd4ca3b4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698