Source/core/svg/SVGGraphicsElement.cpp - Issue 43223002: SVGTests should not leave detached elements in the tree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGGraphicsElement.cpp

Issue 43223002: SVGTests should not leave detached elements in the tree (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Always reattach Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGGraphicsElement.cpp

diff --git a/Source/core/svg/SVGGraphicsElement.cpp b/Source/core/svg/SVGGraphicsElement.cpp

index 9da02b36d0c5be6abf56906c9b2bd9bb4be5a591..5b94695ec82fb5117a72c719f407fe8af3384782 100644

--- a/Source/core/svg/SVGGraphicsElement.cpp

+++ b/Source/core/svg/SVGGraphicsElement.cpp

@@ -129,8 +129,11 @@ void SVGGraphicsElement::svgAttributeChanged(const QualifiedName& attrName)

SVGElementInstance::InvalidationGuard invalidationGuard(this);

- if (SVGTests::handleAttributeChange(this, attrName))

+ // Reattach so the isValid() check will be run again during renderer creation.

+ if (SVGTests::isKnownAttribute(attrName)) {

+ lazyReattachIfAttached();

return;

+ }

RenderObject* object = renderer();

if (!object)