LayoutTests/svg/dynamic-updates/script-tests/SVGTextElement-svgdom-requiredFeatures.js - Issue 43223002: SVGTests should not leave detached elements in the tree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/svg/dynamic-updates/script-tests/SVGTextElement-svgdom-requiredFeatures.js

Issue 43223002: SVGTests should not leave detached elements in the tree (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Always reattach Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/svg/dynamic-updates/script-tests/SVGTextElement-dom-requiredFeatures.js ('k') | LayoutTests/svg/dynamic-updates/script-tests/SVGUseElement-dom-requiredFeatures.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/svg/dynamic-updates/script-tests/SVGTextElement-svgdom-requiredFeatures.js

diff --git a/LayoutTests/svg/dynamic-updates/script-tests/SVGTextElement-svgdom-requiredFeatures.js b/LayoutTests/svg/dynamic-updates/script-tests/SVGTextElement-svgdom-requiredFeatures.js

index ff5e83390164f6c886a1aaf364baaf169fc09acd..4023df12091ca6e8a2bc312da6dd6396f080861d 100644

--- a/LayoutTests/svg/dynamic-updates/script-tests/SVGTextElement-svgdom-requiredFeatures.js

+++ b/LayoutTests/svg/dynamic-updates/script-tests/SVGTextElement-svgdom-requiredFeatures.js

@@ -4,24 +4,25 @@

createSVGTestCase();

var textElement = createSVGElement("text");

+textElement.appendChild(document.createTextNode('Text'));

rootSVGElement.appendChild(textElement);

function repaintTest() {

debug("Check that SVGTextElement is initially displayed");

- shouldBeEqualToString("document.defaultView.getComputedStyle(textElement, null).display", "block");

+ shouldBeTrue("textElement.getBBox().width > 0");

debug("Check that setting requiredFeatures to something invalid makes it not render");

textElement.requiredFeatures.appendItem("http://www.w3.org/TR/SVG11/feature#BogusFeature");

- shouldBeEqualToString("document.defaultView.getComputedStyle(textElement, null).display", "");

+ shouldBe("textElement.getBBox().width", "0");

debug("Check that setting requiredFeatures to something valid makes it render again");

textElement.requiredFeatures.replaceItem("http://www.w3.org/TR/SVG11/feature#Shape", 0);

- shouldBeEqualToString("document.defaultView.getComputedStyle(textElement, null).display", "block");

+ shouldBeTrue("textElement.getBBox().width > 0");

debug("Check that adding something valid to requiredFeatures keeps rendering the element");

textElement.requiredFeatures.appendItem("http://www.w3.org/TR/SVG11/feature#Gradient");

- shouldBeEqualToString("document.defaultView.getComputedStyle(textElement, null).display", "block");

+ shouldBeTrue("textElement.getBBox().width > 0");

debug("Check that adding something invalid to requiredFeatures makes it not render");

textElement.requiredFeatures.appendItem("http://www.w3.org/TR/SVG11/feature#BogusFeature");

- shouldBeEqualToString("document.defaultView.getComputedStyle(textElement, null).display", "");

+ shouldBe("textElement.getBBox().width", "0");

completeTest();

}