Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: LayoutTests/svg/dynamic-updates/script-tests/SVGGElement-svgdom-requiredFeatures.js

Issue 43223002: SVGTests should not leave detached elements in the tree (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Always reattach Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/svg/dynamic-updates/script-tests/SVGGElement-svgdom-requiredFeatures.js
diff --git a/LayoutTests/svg/dynamic-updates/script-tests/SVGGElement-svgdom-requiredFeatures.js b/LayoutTests/svg/dynamic-updates/script-tests/SVGGElement-svgdom-requiredFeatures.js
index 43522b3658de449b557ba6c4ae044e1d6a30d361..58c86dae1e15aed31afac8e278e1c3621da06c5a 100644
--- a/LayoutTests/svg/dynamic-updates/script-tests/SVGGElement-svgdom-requiredFeatures.js
+++ b/LayoutTests/svg/dynamic-updates/script-tests/SVGGElement-svgdom-requiredFeatures.js
@@ -4,24 +4,28 @@
createSVGTestCase();
var gElement = createSVGElement("g");
+var imageElement = createSVGElement("image");
+imageElement.setAttribute("width", "200");
+imageElement.setAttribute("height", "200");
+gElement.appendChild(imageElement);
rootSVGElement.appendChild(gElement);
function repaintTest() {
debug("Check that SVGGElement is initially displayed");
- shouldBeEqualToString("document.defaultView.getComputedStyle(gElement, null).display", "inline");
+ shouldHaveBBox("gElement.firstElementChild", "200", "200");
debug("Check that setting requiredFeatures to something invalid makes it not render");
gElement.requiredFeatures.appendItem("http://www.w3.org/TR/SVG11/feature#BogusFeature");
- shouldBeEqualToString("document.defaultView.getComputedStyle(gElement, null).display", "");
+ shouldHaveBBox("gElement.firstElementChild", "0", "0");
debug("Check that setting requiredFeatures to something valid makes it render again");
gElement.requiredFeatures.replaceItem("http://www.w3.org/TR/SVG11/feature#Shape", 0);
- shouldBeEqualToString("document.defaultView.getComputedStyle(gElement, null).display", "inline");
+ shouldHaveBBox("gElement.firstElementChild", "200", "200");
debug("Check that adding something valid to requiredFeatures keeps rendering the element");
gElement.requiredFeatures.appendItem("http://www.w3.org/TR/SVG11/feature#Gradient");
- shouldBeEqualToString("document.defaultView.getComputedStyle(gElement, null).display", "inline");
+ shouldHaveBBox("gElement.firstElementChild", "200", "200");
debug("Check that adding something invalid to requiredFeatures makes it not render");
gElement.requiredFeatures.appendItem("http://www.w3.org/TR/SVG11/feature#BogusFeature");
- shouldBeEqualToString("document.defaultView.getComputedStyle(gElement, null).display", "");
+ shouldHaveBBox("gElement.firstElementChild", "0", "0");
completeTest();
}

Powered by Google App Engine
This is Rietveld 408576698