SVGTests should not leave detached elements in the tree

Source/core/svg/SVGGraphicsElement.cpp

 /*
  * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  */
 
 #include "config.h"
 
 #include "core/svg/SVGGraphicsElement.h"
 
 #include "SVGNames.h"
 #include "core/rendering/svg/RenderSVGPath.h"
 #include "core/rendering/svg/RenderSVGResource.h"
 #include "core/rendering/svg/SVGPathData.h"
 #include "core/svg/SVGElementInstance.h"
+#include "core/svg/SVGElementRareData.h"
 #include "platform/transforms/AffineTransform.h"
 
 namespace WebCore {
 
 // Animated property definitions
 DEFINE_ANIMATED_TRANSFORM_LIST(SVGGraphicsElement, SVGNames::transformAttr, Transform, transform)
 
 BEGIN_REGISTER_ANIMATED_PROPERTIES(SVGGraphicsElement)
     REGISTER_LOCAL_ANIMATED_PROPERTY(transform)
     REGISTER_PARENT_ANIMATED_PROPERTIES(SVGElement)
@@ skipping 73 matching lines @@
         detachAnimatedTransformListWrappers(newList.size());
         setTransformBaseValue(newList);
         return;
     } else if (SVGTests::parseAttribute(name, value)) {
         return;
     }
 
     ASSERT_NOT_REACHED();
 }
 
+bool SVGGraphicsElement::cachedValidity() const

[pdr., 2013/10/25 06:13:12]

Ditto for this name.

+{
+    if (!hasSVGRareData())
+        return true;
+    return svgRareData()->isValid();
+}
+
 void SVGGraphicsElement::svgAttributeChanged(const QualifiedName& attrName)
 {
     if (!isSupportedAttribute(attrName)) {
         SVGElement::svgAttributeChanged(attrName);
         return;
     }
 
     SVGElementInstance::InvalidationGuard invalidationGuard(this);
 
-    if (SVGTests::handleAttributeChange(this, attrName))
+    if (SVGTests::isKnownAttribute(attrName)) {
+        // FIXME: Need to cast because both SVGTests and SVGElement have isValid()
+        // and SVG code uses multiple inheritance way too much.
+        bool validity = static_cast<SVGElement*>(this)->isValid();

[pdr., 2013/10/25 06:13:12]

Please use toSVGElement here instead of the static cast.

+        if (cachedValidity() != validity) {
+            lazyReattachIfAttached();
+            ensureSVGRareData()->setIsValid(validity);
+        }
         return;
+    }
 
     RenderObject* object = renderer();
     if (!object)
         return;
 
     if (attrName == SVGNames::transformAttr) {
         object->setNeedsTransformUpdate();
         RenderSVGResource::markForLayoutAndParentResourceInvalidation(object);
         return;
     }
@@ skipping 23 matching lines @@
 }
 
 void SVGGraphicsElement::toClipPath(Path& path)
 {
     updatePathFromGraphicsElement(this, path);
     // FIXME: How do we know the element has done a layout?
     path.transform(animatedLocalTransform());
 }
 
 }