SVGTests should not leave detached elements in the tree

Source/core/svg/SVGElementRareData.h

 /*
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 25 matching lines @@
 class SVGElementRareData {
     WTF_MAKE_NONCOPYABLE(SVGElementRareData); WTF_MAKE_FAST_ALLOCATED;
 public:
     SVGElementRareData()
         : m_cursorElement(0)
         , m_cursorImageValue(0)
         , m_correspondingElement(0)
         , m_instancesUpdatesBlocked(false)
         , m_useOverrideComputedStyle(false)
         , m_needsOverrideComputedStyleUpdate(false)
+        , m_isValid(true)
     {
     }
 
     typedef HashMap<const SVGElement*, SVGElementRareData*> SVGElementRareDataMap;
 
     static SVGElementRareDataMap& rareDataMap()
     {
         DEFINE_STATIC_LOCAL(SVGElementRareDataMap, rareDataMap, ());
         return rareDataMap;
     }
@@ skipping 11 matching lines @@
 
     SVGCursorElement* cursorElement() const { return m_cursorElement; }
     void setCursorElement(SVGCursorElement* cursorElement) { m_cursorElement = cursorElement; }
 
     SVGElement* correspondingElement() { return m_correspondingElement; }
     void setCorrespondingElement(SVGElement* correspondingElement) { m_correspondingElement = correspondingElement; }
 
     CSSCursorImageValue* cursorImageValue() const { return m_cursorImageValue; }
     void setCursorImageValue(CSSCursorImageValue* cursorImageValue) { m_cursorImageValue = cursorImageValue; }
 
+    bool isValid() const { return m_isValid; }

[pdr., 2013/10/25 06:13:12]

I'm worried this name will confuse us in the future because it's pretty generic
and overloaded.

Could we go with something more descriptive here such as isValidForSVGTests and
isSVGTestsValidityCached?

+    void setIsValid(bool value) { m_isValid = value; }
+
     MutableStylePropertySet* animatedSMILStyleProperties() const { return m_animatedSMILStyleProperties.get(); }
     MutableStylePropertySet* ensureAnimatedSMILStyleProperties()
     {
         if (!m_animatedSMILStyleProperties)
             m_animatedSMILStyleProperties = MutableStylePropertySet::create(SVGAttributeMode);
         return m_animatedSMILStyleProperties.get();
     }
 
     void destroyAnimatedSMILStyleProperties()
     {
@@ skipping 19 matching lines @@
     void setNeedsOverrideComputedStyleUpdate() { m_needsOverrideComputedStyleUpdate = true; }
 
 private:
     HashSet<SVGElementInstance*> m_elementInstances;
     SVGCursorElement* m_cursorElement;
     CSSCursorImageValue* m_cursorImageValue;
     SVGElement* m_correspondingElement;
     bool m_instancesUpdatesBlocked : 1;
     bool m_useOverrideComputedStyle : 1;
     bool m_needsOverrideComputedStyleUpdate : 1;
+    bool m_isValid : 1;
     RefPtr<MutableStylePropertySet> m_animatedSMILStyleProperties;
     RefPtr<RenderStyle> m_overrideComputedStyle;
 };
 
 }
 
 #endif