Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 432173002: Roll pdfium. This brings in: (Closed)

Created:
6 years, 4 months ago by Nico
Modified:
6 years, 4 months ago
Reviewers:
palmer
CC:
chromium-reviews, Tom Sepez, bo_xu1, jun_fang, scottmg
Project:
chromium
Visibility:
Public.

Description

Roll pdfium. This brings in: 465c2a8 Fix buffer size boundary check offset by 1 90d1f9b Add more |bpc| value check in GetValidBpc() b7e2af9 Fix for min/max compile error on Windows d4ca3b4 Revert 'gn: cross-platform exception disable' 4923e3c gn: cross-platform exception disable ecc73b9 remove .gitattributes to prevent automatic CRLF conversions 515c26b Correct the names of the FX_SAFE_* typedefs. 09363c8 Fix a few more -Wreorder warnings. c2df91c Remove CPDFSDK_Annot::ResetAppearance(). 2fd400c Fix integer overflow when stretch bitmap 10ec7ca Fix uninitialized coords and one of infinite loops 55681f9 Remove a few unused variables, functions, and member variables. ec570e5 Fix a few -Wreorder warnings. 96608b3 Add missing braces for aggregate initializers. f04bd76 Fix potential integer overflow in fpdf_render_loadimage.cpp f1d18bb Attempt to fix some -Woverloaded-virtual warnings. fe08482 Fix incorrect override of GetLayoutOrder(). 8dee6ca Fix the potential integer overflow from 'offset+size' in extension.h and fpdfview.cpp 0d3b5cc Speculative fix for uninitialized value in CFX_ByteString(). cc96527 Fix the typo of "Resources" keyword 621d4de Tidy up app::response(). 6c55495 Fix a few more warnings in chromium_code mode. c77e8f7 Remove a few unused variables, functions, and tables. 3b07e75 Remove 'inline' from two methods. e7e6ca4 CalRGB color correction 3414a64 This change is for fixing the potential integer overflow from "offset + size" BUG=382667, 392956, 391929, 387854, 395636 TBR=palmer@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287263

Patch Set 1 #

Patch Set 2 : b7e2af924f5ea820d9ccfed4afa675bf32e76c6f #

Patch Set 3 : 465c2a84ba709d932040c9e80db508e93c138da6 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (0 generated)
Nico
6 years, 4 months ago (2014-07-31 22:14:36 UTC) #1
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 4 months ago (2014-07-31 22:16:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/432173002/1
6 years, 4 months ago (2014-07-31 22:18:05 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-01 02:03:28 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-01 02:14:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/builds/2160)
6 years, 4 months ago (2014-08-01 02:14:04 UTC) #6
Nico
6 years, 4 months ago (2014-08-01 14:31:29 UTC) #7
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 4 months ago (2014-08-01 14:31:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/432173002/20001
6 years, 4 months ago (2014-08-01 14:34:23 UTC) #9
palmer
lgtm
6 years, 4 months ago (2014-08-01 18:28:00 UTC) #10
Nico
The CQ bit was unchecked by thakis@chromium.org
6 years, 4 months ago (2014-08-01 22:03:00 UTC) #11
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 4 months ago (2014-08-01 22:03:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/432173002/20001
6 years, 4 months ago (2014-08-01 22:04:35 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-02 06:36:48 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-02 08:02:28 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/builds/2460)
6 years, 4 months ago (2014-08-02 08:02:32 UTC) #16
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 4 months ago (2014-08-03 15:25:09 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/432173002/40001
6 years, 4 months ago (2014-08-03 15:26:12 UTC) #18
commit-bot: I haz the power
6 years, 4 months ago (2014-08-03 20:54:11 UTC) #19
Message was sent while issue was closed.
Change committed as 287263

Powered by Google App Engine
This is Rietveld 408576698