Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 432143002: Add ETC1 format to SkTextureCompressor (Closed)

Created:
6 years, 4 months ago by krajcevski
Modified:
6 years, 4 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add default clause to texture compressor. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -16 lines) Patch
M gyp/utils.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/images/SkImageDecoder_pkm.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M src/utils/SkTextureCompressor.h View 2 chunks +13 lines, -8 lines 0 comments Download
M src/utils/SkTextureCompressor.cpp View 1 5 chunks +39 lines, -2 lines 0 comments Download
M tests/TextureCompressionTest.cpp View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
krajcevski
6 years, 4 months ago (2014-07-31 21:34:49 UTC) #1
robertphillips
lgtm
6 years, 4 months ago (2014-08-04 15:32:37 UTC) #2
krajcevski
The CQ bit was checked by krajcevski@google.com
6 years, 4 months ago (2014-08-04 15:43:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/432143002/1
6 years, 4 months ago (2014-08-04 15:44:17 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on tryserver.skia ...
6 years, 4 months ago (2014-08-04 15:58:43 UTC) #5
commit-bot: I haz the power
Change committed as 5d8b1b44ea7636fc8e98247cb311568f277ce3a5
6 years, 4 months ago (2014-08-04 16:08:35 UTC) #6
krajcevski
A revert of this CL has been created in https://codereview.chromium.org/438443004/ by krajcevski@google.com. The reason for ...
6 years, 4 months ago (2014-08-04 16:46:58 UTC) #7
krajcevski
The CQ bit was checked by krajcevski@google.com
6 years, 4 months ago (2014-08-04 21:05:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/432143002/20001
6 years, 4 months ago (2014-08-04 21:05:49 UTC) #9
krajcevski
The CQ bit was unchecked by krajcevski@google.com
6 years, 4 months ago (2014-08-05 14:33:16 UTC) #10
krajcevski
The CQ bit was checked by krajcevski@google.com
6 years, 4 months ago (2014-08-05 14:33:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/432143002/20001
6 years, 4 months ago (2014-08-05 14:33:25 UTC) #12
krajcevski
The CQ bit was unchecked by krajcevski@google.com
6 years, 4 months ago (2014-08-05 14:34:13 UTC) #13
krajcevski
The CQ bit was checked by krajcevski@google.com
6 years, 4 months ago (2014-08-05 14:34:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/432143002/20001
6 years, 4 months ago (2014-08-05 14:34:25 UTC) #15
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 14:37:33 UTC) #16
Message was sent while issue was closed. 
Change committed as e90c900ed7b2be3d0f9c7134d7fcd5f820b0464c

Powered by Google App Engine
This is Rietveld 408576698