Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 432133002: Add expected files for print preview end to end testing on windows. (Closed)

Created:
6 years, 4 months ago by ivandavid
Modified:
6 years, 4 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, Dan Beam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add expected files for print preview end to end testing on windows. NOTRY=true BUG=388517 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287678

Patch Set 1 #

Patch Set 2 : Uploaded windows expected files. #

Patch Set 3 : Removed test case and its expected file, updated TestExpectations. #

Patch Set 4 : Brought back color gradient test, updated TestExpectations. #

Patch Set 5 : Fixed file path in TestExpectations, fixed the formatting in TestExpectations to follow the correct… #

Patch Set 6 : Updated TestExpectations to include crbug link. #

Patch Set 7 : Updated expected pngs so they have the correct DPI. #

Total comments: 2

Patch Set 8 : Undid changes to color-gradient.html #

Patch Set 9 : Replaced old PNGs with crushed PNGs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
A chrome/test/data/printing/layout_tests/TestExpectations View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
A + chrome/test/data/printing/layout_tests/platform/win/source_html/colors/color-gradient-expected.png View 1 2 3 4 5 6 7 8 Binary file 0 comments Download
A chrome/test/data/printing/layout_tests/platform/win/source_html/forms/radio-expected.png View 1 2 3 4 5 6 7 8 Binary file 0 comments Download
A chrome/test/data/printing/layout_tests/platform/win/source_html/forms/text-field-expected.png View 1 2 3 4 5 6 7 8 Binary file 0 comments Download
A chrome/test/data/printing/layout_tests/platform/win/source_html/images/test-image-expected.png View 1 2 3 4 5 6 7 8 Binary file 0 comments Download
A chrome/test/data/printing/layout_tests/platform/win/source_html/shapes/empty-box-expected.png View 1 2 3 4 5 6 7 8 Binary file 0 comments Download
A + chrome/test/data/printing/layout_tests/platform/win/source_html/shapes/lines-expected.png View 1 2 3 4 5 6 7 8 Binary file 0 comments Download
A chrome/test/data/printing/layout_tests/platform/win/source_html/text/bullet-list-expected.png View 1 2 3 4 5 6 7 8 Binary file 0 comments Download
A chrome/test/data/printing/layout_tests/platform/win/source_html/text/simple-text-expected.png View 1 2 3 4 5 6 7 8 Binary file 0 comments Download
A chrome/test/data/printing/layout_tests/platform/win/source_pdf/portrait_landscape-expected.png View 1 2 3 4 5 6 7 8 Binary file 0 comments Download

Messages

Total messages: 18 (0 generated)
ivandavid
6 years, 4 months ago (2014-07-31 21:15:40 UTC) #1
Lei Zhang
Do you even need the text files? Why not do Windows first, since that's the ...
6 years, 4 months ago (2014-07-31 21:18:39 UTC) #2
ivandavid
On 2014/07/31 21:18:39, Lei Zhang wrote: > Do you even need the text files? > ...
6 years, 4 months ago (2014-08-01 02:34:30 UTC) #3
Lei Zhang
To repeat our in-person conversation for the record: - Don't delete a test just because ...
6 years, 4 months ago (2014-08-01 03:04:11 UTC) #4
ivandavid
On 2014/08/01 03:04:11, Lei Zhang wrote: > To repeat our in-person conversation for the record: ...
6 years, 4 months ago (2014-08-01 23:01:03 UTC) #5
Lei Zhang
Let me see if I can crush some PNGs... https://codereview.chromium.org/432133002/diff/160001/chrome/test/data/printing/layout_tests/source_html/colors/color-gradient.html File chrome/test/data/printing/layout_tests/source_html/colors/color-gradient.html (right): https://codereview.chromium.org/432133002/diff/160001/chrome/test/data/printing/layout_tests/source_html/colors/color-gradient.html#newcode18 chrome/test/data/printing/layout_tests/source_html/colors/color-gradient.html:18: ...
6 years, 4 months ago (2014-08-01 23:47:46 UTC) #6
ivandavid
https://codereview.chromium.org/432133002/diff/160001/chrome/test/data/printing/layout_tests/source_html/colors/color-gradient.html File chrome/test/data/printing/layout_tests/source_html/colors/color-gradient.html (right): https://codereview.chromium.org/432133002/diff/160001/chrome/test/data/printing/layout_tests/source_html/colors/color-gradient.html#newcode18 chrome/test/data/printing/layout_tests/source_html/colors/color-gradient.html:18: </html> On 2014/08/01 23:47:46, Lei Zhang wrote: > unwanted ...
6 years, 4 months ago (2014-08-02 00:14:40 UTC) #7
Lei Zhang
LGTM once I have some optimized PNGs for you. You can add: NOTRY=true on a ...
6 years, 4 months ago (2014-08-02 01:03:06 UTC) #8
ivandavid
The CQ bit was checked by ivandavid@chromium.org
6 years, 4 months ago (2014-08-02 01:04:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivandavid@chromium.org/432133002/200001
6 years, 4 months ago (2014-08-02 01:05:14 UTC) #10
Lei Zhang
The CQ bit was unchecked by thestig@chromium.org
6 years, 4 months ago (2014-08-02 01:05:48 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-02 01:06:47 UTC) #12
ivandavid
The CQ bit was checked by ivandavid@chromium.org
6 years, 4 months ago (2014-08-02 01:59:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivandavid@chromium.org/432133002/220001
6 years, 4 months ago (2014-08-02 02:01:15 UTC) #14
ivandavid
The CQ bit was unchecked by ivandavid@chromium.org
6 years, 4 months ago (2014-08-02 02:14:19 UTC) #15
ivandavid
The CQ bit was checked by ivandavid@chromium.org
6 years, 4 months ago (2014-08-06 01:15:51 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivandavid@chromium.org/432133002/220001
6 years, 4 months ago (2014-08-06 01:18:09 UTC) #17
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 04:39:15 UTC) #18
Message was sent while issue was closed.
Change committed as 287678

Powered by Google App Engine
This is Rietveld 408576698