fix warning in third_party/leveldatabase/chromium_logger.h

third_party/leveldatabase/chromium_logger.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef THIRD_PARTY_LEVELDATABASE_CHROMIUM_LOGGER_H_
 #define THIRD_PARTY_LEVELDATABASE_CHROMIUM_LOGGER_H_
 
 #include <stdio.h>
 
 #include <algorithm>
@@ skipping 28 matching lines @@
         bufsize = 30000;
         base = new char[bufsize];
       }
       char* p = base;
       char* limit = base + bufsize;
 
       ::base::Time::Exploded t;
       ::base::Time::Now().LocalExplode(&t);
 
       p += ::base::snprintf(p, limit - p,
-                    "%04d/%02d/%02d-%02d:%02d:%02d.%03d %" PRIu64 " ",

[cmumford, 2014/07/31 20:56:13]

On some platforms (OSX I believe) pid_t (PlatformThreadId) is a *signed*
integer, and on others it's a long long unsigned. I'm not sure, but this might
get you into trouble. The last time I touched this code I was tempted to convert
this to std::ostringstream.

I think that if this passes the buildbots you'll be OK.

[Mostyn Bramley-Moore, 2014/07/31 21:22:17]

(I'll switch to jsbell's suggestion.)
The mac_chromium_compile_rel trybot thought it didn't need to recompile with
this patch, I wonder if that's a bug on the trybot?

+                    "%04d/%02d/%02d-%02d:%02d:%02d.%03d %llu ",
                     t.year,
                     t.month,
                     t.day_of_month,
                     t.hour,
                     t.minute,
                     t.second,
                     t.millisecond,
                     static_cast<long long unsigned int>(thread_id));
 
       // Print the message
@@ skipping 28 matching lines @@
     }
   }
 
  private:
   FILE* file_;
 };
 
 }  // namespace leveldb
 
 #endif  // THIRD_PARTY_LEVELDATABASE_CHROMIUM_LOGGER_H_