Remove GestureEventFilter and clean up related bits assuming that we turn on

content/browser/renderer_host/input/immediate_input_router.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/input/immediate_input_router.h"
 
 #include "base/auto_reset.h"
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
-#include "content/browser/renderer_host/input/gesture_event_filter.h"
+#include "content/browser/renderer_host/input/base_gesture_event_filter.h"
 #include "content/browser/renderer_host/input/input_ack_handler.h"
 #include "content/browser/renderer_host/input/input_router_client.h"
 #include "content/browser/renderer_host/input/touch_event_queue.h"
-#include "content/browser/renderer_host/input/touchpad_tap_suppression_controller.h"
 #include "content/browser/renderer_host/overscroll_controller.h"
 #include "content/common/content_constants_internal.h"
 #include "content/common/edit_command.h"
 #include "content/common/input/web_input_event_traits.h"
 #include "content/common/input_messages.h"
 #include "content/common/view_messages.h"
 #include "content/port/common/input_event_ack_state.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/user_metrics.h"
@@ skipping 38 matching lines @@
     case INPUT_EVENT_ACK_STATE_CONSUMED: return "CONSUMED";
     case INPUT_EVENT_ACK_STATE_NOT_CONSUMED: return "NOT_CONSUMED";
     case INPUT_EVENT_ACK_STATE_NO_CONSUMER_EXISTS: return "NO_CONSUMER_EXISTS";
   default:
     DLOG(WARNING) << "Unhandled InputEventAckState in GetEventAckName.\n";
     break;
   }
   return "";
 }
 
-bool BrowserSideFlingEnabled() {
-  return CommandLine::ForCurrentProcess()->HasSwitch(
-      switches::kEnableBrowserSideFling);
-}
-
 } // namespace
 
-// A helper class that based on the value of the |kEnableBrowserSideFling| flag
-// does event filtering using either |BaseGestureEventFilter| or
-// |GestureEventFilter|.
-class ImmediateInputRouter::EventFilteringHelper {
- public:
-  // |router| must outlive us.
-  explicit EventFilteringHelper(ImmediateInputRouter* router) {
-    if (BrowserSideFlingEnabled())
-      gesture_event_filter_.reset(new BaseGestureEventFilter(router));
-    else
-      gesture_event_filter_.reset(new GestureEventFilter(router, router));
-  }
-  virtual ~EventFilteringHelper() {}
-
-  bool ShouldDeferMouseDown(const MouseEventWithLatencyInfo& mouse_event) {
-    if (BrowserSideFlingEnabled())
-      return false;
-
-    return static_cast<GestureEventFilter*>(gesture_event_filter_.get())->
-        GetTouchpadTapSuppressionController()->ShouldDeferMouseDown(
-            mouse_event);
-  }
-
-  bool ShouldDeferMouseUp(const MouseEventWithLatencyInfo& mouse_event) {
-    if (BrowserSideFlingEnabled())
-      return false;
-
-    return static_cast<GestureEventFilter*>(gesture_event_filter_.get())->
-        GetTouchpadTapSuppressionController()->ShouldSuppressMouseUp();
-  }
-
-  void FlingHasBeenHalted() {
-    if (BrowserSideFlingEnabled())
-      return;
-
-    static_cast<GestureEventFilter*>(gesture_event_filter_.get())->
-        FlingHasBeenHalted();
-  }
-
-  bool ShouldForwardGesture(const GestureEventWithLatencyInfo& gesture_event) {
-    return gesture_event_filter_->ShouldForward(gesture_event);
-  }
-
-  bool HasQueuedGestureEvents() {
-    return gesture_event_filter_->HasQueuedGestureEvents();
-  }
-
-  void ProcessGestureAck(InputEventAckState ack_result,
-                         WebKit::WebInputEvent::Type type,
-                         const ui::LatencyInfo& latency) {
-    gesture_event_filter_->ProcessGestureAck(ack_result, type, latency);
-  }
-
- private:
-  friend class ImmediateInputRouter;
-  scoped_ptr<BaseGestureEventFilter> gesture_event_filter_;
-
-  DISALLOW_COPY_AND_ASSIGN(EventFilteringHelper);
-};
-
 ImmediateInputRouter::ImmediateInputRouter(IPC::Sender* sender,
                                            InputRouterClient* client,
                                            InputAckHandler* ack_handler,
                                            int routing_id)
     : sender_(sender),
       client_(client),
       ack_handler_(ack_handler),
       routing_id_(routing_id),
       select_range_pending_(false),
       move_caret_pending_(false),
       mouse_move_pending_(false),
       mouse_wheel_pending_(false),
       has_touch_handler_(false),
       current_ack_source_(ACK_SOURCE_NONE),
       touch_event_queue_(new TouchEventQueue(this)),
       flinger_(new Flinger(this)),
-      event_filter_(new EventFilteringHelper(this)) {
+      event_filter_(new BaseGestureEventFilter(this)) {
   DCHECK(sender);
   DCHECK(client);
   DCHECK(ack_handler);
 }
 
 ImmediateInputRouter::~ImmediateInputRouter() {
 }
 
 void ImmediateInputRouter::Flush() {
   NOTREACHED() << "ImmediateInputRouter will never request a flush.";
@@ skipping 11 matching lines @@
       NOTREACHED() << "WebInputEvents should never be sent via SendInput.";
       return false;
     default:
       return Send(message.release());
   }
 }
 
 void ImmediateInputRouter::SendMouseEvent(
     const MouseEventWithLatencyInfo& mouse_event) {
   // Order is important here; we need to convert all MouseEvents before they
-  // propagate further, e.g., to the tap suppression controller.
+  // propagate further.
   if (CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kSimulateTouchScreenWithMouse)) {
     SimulateTouchGestureWithMouse(mouse_event);
     return;
   }
 
-  if (BrowserSideFlingEnabled() && flinger_->HandleMouseEvent(mouse_event))
+  if (flinger_->HandleMouseEvent(mouse_event))
     return;
 
-  if (mouse_event.event.type == WebInputEvent::MouseDown &&
-      event_filter_->ShouldDeferMouseDown(mouse_event))
-      return;
-  if (mouse_event.event.type == WebInputEvent::MouseUp &&
-      event_filter_->ShouldDeferMouseUp(mouse_event))
-      return;
-
   SendMouseEventImmediately(mouse_event);
 }
 
 void ImmediateInputRouter::SendWheelEvent(
     const MouseWheelEventWithLatencyInfo& wheel_event) {
-  if (BrowserSideFlingEnabled() && flinger_->HandleWheelEvent(wheel_event))
+  if (flinger_->HandleWheelEvent(wheel_event))
     return;
 
   // If there's already a mouse wheel event waiting to be sent to the renderer,
   // add the new deltas to that event. Not doing so (e.g., by dropping the old
   // event, as for mouse moves) results in very slow scrolling on the Mac (on
   // which many, very small wheel events are sent).
   if (mouse_wheel_pending_) {
     if (coalesced_mouse_wheel_events_.empty() ||
         !coalesced_mouse_wheel_events_.back().CanCoalesceWith(wheel_event)) {
       coalesced_mouse_wheel_events_.push_back(wheel_event);
     } else {
       coalesced_mouse_wheel_events_.back().CoalesceWith(wheel_event);
     }
     return;
   }
   mouse_wheel_pending_ = true;
   current_wheel_event_ = wheel_event;
 
   HISTOGRAM_COUNTS_100("Renderer.WheelQueueSize",
                        coalesced_mouse_wheel_events_.size());
 
   FilterAndSendWebInputEvent(wheel_event.event, wheel_event.latency, false);
 }
 
 void ImmediateInputRouter::SendKeyboardEvent(
     const NativeWebKeyboardEvent& key_event,
     const ui::LatencyInfo& latency_info,
     bool is_keyboard_shortcut) {
-  if (BrowserSideFlingEnabled() && flinger_->HandleKeyboardEvent())
+  if (flinger_->HandleKeyboardEvent())
     return;
 
   // Put all WebKeyboardEvent objects in a queue since we can't trust the
   // renderer and we need to give something to the HandleKeyboardEvent
   // handler.
   key_queue_.push_back(key_event);
   HISTOGRAM_COUNTS_100("Renderer.KeyboardQueueSize", key_queue_.size());
 
-  event_filter_->FlingHasBeenHalted();
-
   // Only forward the non-native portions of our event.
   FilterAndSendWebInputEvent(key_event, latency_info, is_keyboard_shortcut);
 }
 
 void ImmediateInputRouter::SendGestureEvent(
     const GestureEventWithLatencyInfo& gesture_event) {
   HandleGestureScroll(gesture_event);
 
-  if (BrowserSideFlingEnabled() && flinger_->HandleGestureEvent(gesture_event))
+  if (flinger_->HandleGestureEvent(gesture_event))
     return;
 
   if (!IsInOverscrollGesture() &&
-      !event_filter_->ShouldForwardGesture(gesture_event)) {
+      !event_filter_->ShouldForward(gesture_event)) {
     OverscrollController* controller = client_->GetOverscrollController();
     if (controller)
       controller->DiscardingGestureEvent(gesture_event.event);
     return;
   }
 
   FilterAndSendWebInputEvent(gesture_event.event, gesture_event.latency, false);
 }
 
 void ImmediateInputRouter::SendTouchEvent(
     const TouchEventWithLatencyInfo& touch_event) {
   touch_event_queue_->QueueEvent(touch_event);
 }
 
-// Forwards MouseEvent without passing it through
-// TouchpadTapSuppressionController.
 void ImmediateInputRouter::SendMouseEventImmediately(
     const MouseEventWithLatencyInfo& mouse_event) {
   // Avoid spamming the renderer with mouse move events.  It is important
   // to note that WM_MOUSEMOVE events are anyways synthetic, but since our
   // thread is able to rapidly consume WM_MOUSEMOVE events, we may get way
   // more WM_MOUSEMOVE events than we wish to send to the renderer.
   if (mouse_event.event.type == WebInputEvent::MouseMove) {
     if (mouse_move_pending_) {
       if (!next_mouse_move_)
         next_mouse_move_.reset(new MouseEventWithLatencyInfo(mouse_event));
@@ skipping 162 matching lines @@
   OverscrollController::Disposition disposition =
       controller->DispatchEvent(input_event, latency_info);
 
   bool consumed = disposition == OverscrollController::CONSUMED;
 
   if (disposition == OverscrollController::SHOULD_FORWARD_TO_GESTURE_FILTER) {
     DCHECK(WebInputEvent::isGestureEventType(input_event.type));
     const WebKit::WebGestureEvent& gesture_event =
         static_cast<const WebKit::WebGestureEvent&>(input_event);
     // An ACK is expected for the event, so mark it as consumed.
-    consumed = !event_filter_->ShouldForwardGesture(
+    consumed = !event_filter_->ShouldForward(
         GestureEventWithLatencyInfo(gesture_event, latency_info));
   }
 
   if (consumed) {
     InputEventAckState overscroll_ack =
         WebInputEvent::isTouchEventType(input_event.type) ?
             INPUT_EVENT_ACK_STATE_NOT_CONSUMED : INPUT_EVENT_ACK_STATE_CONSUMED;
     ProcessInputEventAck(input_event.type,
                          overscroll_ack,
                          latency_info,
@@ skipping 297 matching lines @@
     case WebMouseEvent::ButtonNone:
       break;
   }
 }
 
 bool ImmediateInputRouter::IsInOverscrollGesture() const {
   OverscrollController* controller = client_->GetOverscrollController();
   return controller && controller->overscroll_mode() != OVERSCROLL_NONE;
 }
 
-BaseGestureEventFilter* ImmediateInputRouter::gesture_event_filter() {
-  return event_filter_->gesture_event_filter_.get();
-}
-
 }  // namespace content