Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5642)

Unified Diff: chrome/browser/chromeos/settings/device_oauth2_token_service.cc

Issue 43203002: Remove hacks added to workaround a system salt issue for M31 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/app_mode/startup_app_launcher.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/settings/device_oauth2_token_service.cc
diff --git a/chrome/browser/chromeos/settings/device_oauth2_token_service.cc b/chrome/browser/chromeos/settings/device_oauth2_token_service.cc
index 64f2c8400094cf9a6557bd22c43cfd9304dbd382..79ad2d1945b24d368fc50d435fcca763889955c1 100644
--- a/chrome/browser/chromeos/settings/device_oauth2_token_service.cc
+++ b/chrome/browser/chromeos/settings/device_oauth2_token_service.cc
@@ -16,7 +16,6 @@
#include "chrome/browser/policy/browser_policy_connector.h"
#include "chrome/browser/policy/proto/cloud/device_management_backend.pb.h"
#include "chrome/common/pref_names.h"
-#include "chromeos/cryptohome/system_salt_getter.h"
#include "content/public/browser/browser_thread.h"
#include "google_apis/gaia/gaia_urls.h"
#include "google_apis/gaia/google_service_auth_error.h"
@@ -237,20 +236,6 @@ void DeviceOAuth2TokenService::SetAndSaveRefreshToken(
const std::string& refresh_token) {
DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
- // TODO(xiyuan): Use async GetSystemSalt after merging to M31.
- const std::string system_salt = SystemSaltGetter::Get()->GetSystemSaltSync();
- if (system_salt.empty()) {
- const int64 kRequestSystemSaltDelayMs = 500;
- content::BrowserThread::PostDelayedTask(
- content::BrowserThread::UI,
- FROM_HERE,
- base::Bind(&DeviceOAuth2TokenService::SetAndSaveRefreshToken,
- weak_ptr_factory_.GetWeakPtr(),
- refresh_token),
- base::TimeDelta::FromMilliseconds(kRequestSystemSaltDelayMs));
- return;
- }
-
std::string encrypted_refresh_token =
token_encryptor_->EncryptWithSystemSalt(refresh_token);
@@ -265,10 +250,6 @@ std::string DeviceOAuth2TokenService::GetRefreshToken(
std::string encrypted_refresh_token =
local_state_->GetString(prefs::kDeviceRobotAnyApiRefreshToken);
- // TODO(xiyuan): This needs a proper fix after M31.
- LOG_IF(ERROR, SystemSaltGetter::Get()->GetSystemSaltSync().empty())
- << "System salt is not available for decryption";
-
refresh_token_ = token_encryptor_->DecryptWithSystemSalt(
encrypted_refresh_token);
}
« no previous file with comments | « chrome/browser/chromeos/app_mode/startup_app_launcher.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698