Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2801)

Unified Diff: chrome/browser/chromeos/app_mode/startup_app_launcher.cc

Issue 43203002: Remove hacks added to workaround a system salt issue for M31 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/settings/device_oauth2_token_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/app_mode/startup_app_launcher.cc
diff --git a/chrome/browser/chromeos/app_mode/startup_app_launcher.cc b/chrome/browser/chromeos/app_mode/startup_app_launcher.cc
index 170d3527bd2021d72e920b52db6cef26857b1c3f..6ec7dbfdabafadcd8019d167d0e061576f51254a 100644
--- a/chrome/browser/chromeos/app_mode/startup_app_launcher.cc
+++ b/chrome/browser/chromeos/app_mode/startup_app_launcher.cc
@@ -250,7 +250,7 @@ void StartupAppLauncher::BeginInstall() {
<< net::NetworkChangeNotifier::GetConnectionType();
if (IsAppInstalled(profile_, app_id_)) {
- EnsureSystemSaltIsLoaded();
+ OnReadyToLaunch();
return;
}
@@ -271,7 +271,7 @@ void StartupAppLauncher::InstallCallback(bool success,
BrowserThread::PostTask(
BrowserThread::UI,
FROM_HERE,
- base::Bind(&StartupAppLauncher::EnsureSystemSaltIsLoaded,
+ base::Bind(&StartupAppLauncher::OnReadyToLaunch,
AsWeakPtr()));
return;
}
@@ -280,13 +280,6 @@ void StartupAppLauncher::InstallCallback(bool success,
OnLaunchFailure(KioskAppLaunchError::UNABLE_TO_INSTALL);
}
-void StartupAppLauncher::EnsureSystemSaltIsLoaded() {
- // Defer app launch until system salt is loaded to make sure that identity
- // api works with the enterprise kiosk app.
- SystemSaltGetter::Get()->GetSystemSalt(
- base::Bind(&StartupAppLauncher::OnReadyToLaunch, AsWeakPtr()));
-}
-
void StartupAppLauncher::OnReadyToLaunch(const std::string& system_salt) {
hashimoto 2013/10/25 05:08:01 This argument should be removed.
satorux1 2013/10/25 05:11:21 oops. too early to upload. fixed.
if (system_salt.empty()) {
LOG(ERROR) << "Could not load system salt.";
« no previous file with comments | « no previous file | chrome/browser/chromeos/settings/device_oauth2_token_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698