Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 432023003: Do not put an 'r' in front of the revision when commenting on Rietveld after committing. (Closed)

Created:
6 years, 4 months ago by Robert Sesek
Modified:
6 years, 4 months ago
Reviewers:
agable, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Project:
tools
Visibility:
Public.

Description

Do not put an 'r' in front of the revision when commenting on Rietveld after committing. When using `git cl land` this would result in r<hash>, which is not desirable. R=maruel@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=286931

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M git_cl.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Robert Sesek
Commit-bot doesn't do this anymore, fwiw.
6 years, 4 months ago (2014-07-31 16:19:33 UTC) #1
Robert Sesek
Looks like agable@ is at an offsite. maruel@: mind taking a look?
6 years, 4 months ago (2014-07-31 17:47:14 UTC) #2
M-A Ruel
lgtm
6 years, 4 months ago (2014-08-01 01:03:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/432023003/1
6 years, 4 months ago (2014-08-01 01:04:14 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-01 01:06:25 UTC) #5
Message was sent while issue was closed.
Change committed as 286931

Powered by Google App Engine
This is Rietveld 408576698