Issue 432022: Merge 32930 - Mac: improve hover/clicked state appearance of bookmark bar but...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 432022: Merge 32930 - Mac: improve hover/clicked state appearance of bookmark bar but... (Closed)

Created:
11 years ago by viettrungluu

Modified:
9 years, 6 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/249/src/

Visibility:
Public.

Description

Merge 32930 - Mac: improve hover/clicked state appearance of bookmark bar buttons. I more or less implemented things as per discussion with Cole and Glen. (This does not recreate the appearance on Win Chrome, which is not exactly right either.) BUG=28477 TEST=Load various themes (in particular, "Karim Rashid") and make sure bookmark bar buttons look good and legible in hover and pressed states. Review URL: http://codereview.chromium.org/440001 TBR=viettrungluu@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33071

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -33 lines)			Patch
	M	chrome/browser/cocoa/gradient_button_cell.mm	View		9 chunks	+56 lines, -33 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages