Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 432021: Branch new tcmalloc_linux.cc into new chromium\src branch. Update new... (Closed)

Created:
11 years, 1 month ago by sgk
Modified:
9 years, 5 months ago
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org
Visibility:
Public.

Description

Branch new tcmalloc_linux.cc into new chromium\src branch. Update new base\allocator\allocator.gyp with merged changes from tcmalloc.gyp. BUG=27911 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33047

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, --1 lines) Patch
MM base/allocator/allocator.gyp View 2 chunks +4 lines, -0 lines 0 comments Download
A + third_party/tcmalloc/chromium/src/tcmalloc_linux.cc View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sgk
TBR=willchan Note that this doesn't bring over your "unfork this" TODO for tcmalloc.cc itself, because ...
11 years, 1 month ago (2009-11-25 04:11:32 UTC) #1
willchan no longer on Chromium
11 years ago (2009-11-25 18:24:45 UTC) #2
LGTM

On Tue, Nov 24, 2009 at 8:11 PM,  <sgk@chromium.org> wrote:
> Reviewers: willchan,
>
> Message:
> TBR=willchan
>
> Note that this doesn't bring over your "unfork this" TODO for tcmalloc.cc
> itself, because that's globally excluded earlier in the file.
>
>
> Description:
> Branch new tcmalloc_linux.cc into new chromium\src branch.  Update new
> base\allocator\allocator.gyp with merged changes from tcmalloc.gyp.
> BUG=27911
> TEST=none
>
> Please review this at http://codereview.chromium.org/432021
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  MM    base/allocator/allocator.gyp
>  A  +  third_party/tcmalloc/chromium/src/tcmalloc_linux.cc
>
>
>
> Property changes on: third_party\tcmalloc\chromium\src\tcmalloc_linux.cc
> ___________________________________________________________________
> Added: svn:eol-style
>   + LF
>
> Index: base/allocator/allocator.gyp
> ===================================================================
> --- base/allocator/allocator.gyp        (revision 33043)
> +++ base/allocator/allocator.gyp        (working copy)
> @@ -103,6 +103,7 @@
>         '<(tcmalloc_dir)/src/system-alloc.cc',
>         '<(tcmalloc_dir)/src/system-alloc.h',
>         '<(tcmalloc_dir)/src/tcmalloc.cc',
> +        '<(tcmalloc_dir)/src/tcmalloc_linux.cc',
>
>         # heap-profiler/checker/cpuprofiler
>         '<(tcmalloc_dir)/src/base/thread_lister.c',
> @@ -181,6 +182,9 @@
>             '<(tcmalloc_dir)/src/system-alloc.cc',
>             '<(tcmalloc_dir)/src/system-alloc.h',
>
> +            # don't use linux forked version
> +            '<(tcmalloc_dir)/src/tcmalloc_linux.cc',
> +
>             # heap-profiler/checker/cpuprofiler
>             '<(tcmalloc_dir)/src/base/thread_lister.c',
>             '<(tcmalloc_dir)/src/base/thread_lister.h',
>
> Property changes on: base\allocator\allocator.gyp
> ___________________________________________________________________
> Added: svn:mergeinfo
>   Merged
> /branches/chrome_webkit_merge_branch/base/allocator/allocator.gyp:r69-2775
>   Merged /trunk/src/third_party/tcmalloc/tcmalloc.gyp:r33010
>
>
>
>

Powered by Google App Engine
This is Rietveld 408576698