Issue 432019: Posix: Catch SIGINT and do a clean shutdown....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 432019: Posix: Catch SIGINT and do a clean shutdown.... (Closed)

Created:
11 years, 1 month ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
agl, Evan Martin

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org, stuartmorgan

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Posix: Catch SIGHUP/SIGINT and do a clean shutdown. BUG=28746 TEST=Ctrl+C = clean shutdown. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33046

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : and don't forget sighup #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -9 lines)			Patch
	M	chrome/browser/browser_main.cc	View	1 2	3 chunks	+31 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

LGTM agl may have comments too, but don't wait for 'em :) http://codereview.chromium.org/432019/diff/1/2 File chrome/browser/browser_main.cc ...

11 years, 1 month ago (2009-11-25 01:09:22 UTC) #2

Lei Zhang

11 years, 1 month ago (2009-11-25 03:49:04 UTC) #3

On 2009/11/25 01:09:22, Evan Martin wrote:
> LGTM
> 
> agl may have comments too, but don't wait for 'em :)
> 
> http://codereview.chromium.org/432019/diff/1/2
> File chrome/browser/browser_main.cc (right):
> 
> http://codereview.chromium.org/432019/diff/1/2#newcode184
> chrome/browser/browser_main.cc:184: // Reinstall the default handler.  We had
> one shot at graceful shutdown.
> I wonder if this code should move above the if (posted) test, then the below
if
> (!posted) would be an else on the above if

Ok. And I remembered we should do the same for SIGHUP.

Expand Messages | Collapse Messages