Make notifications permission available in the extension manifest and hook up...

Make notifications permission available in the extension manifest and hook up to the desktop notification service.

BUG=27249
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32979

[Aaron Boodman, 2009-11-24 20:38:14]

Additionally, one problem is that the install UI doesn't warn the user about
this permission.

We need to generalize the install UI to be more scalable so that we can do
things like this more easily. That can be a different change though, and isn't
really your problem.

http://codereview.chromium.org/432005/diff/2009/3002
File chrome/browser/notifications/desktop_notification_service.cc (right):

http://codereview.chromium.org/432005/diff/2009/3002#newcode227
chrome/browser/notifications/desktop_notification_service.cc:227:
prefs_cache_->CacheAllowedOrigin((*iter)->url());
Why do you need to store this state again? It is already stored in the extension
system.

[John Gregg, 2009-11-24 20:52:44]

http://codereview.chromium.org/432005/diff/2009/3002
File chrome/browser/notifications/desktop_notification_service.cc (right):

http://codereview.chromium.org/432005/diff/2009/3002#newcode227
chrome/browser/notifications/desktop_notification_service.cc:227:
prefs_cache_->CacheAllowedOrigin((*iter)->url());
On 2009/11/24 20:38:14, Aaron Boodman wrote:
> Why do you need to store this state again? It is already stored in the
extension
> system.

I need this state on the IO thread to respond to a synchronous IPC for a
synchronous checkPermission() JS call that's part of the Notifications API.  

So all the notifications permission state (including the stuff I store
persistently on the profile) is cached in this PrefsCache that lives on the IO
thread.

[Aaron Boodman, 2009-11-24 21:36:53]

Ah, I see.

LGTM