Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Unified Diff: bench/nanobench.cpp

Issue 431983006: Skip all .skps in 565. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bench/nanobench.cpp
diff --git a/bench/nanobench.cpp b/bench/nanobench.cpp
index f6fd90e74a81e3086d1f2a4d6228793cf6b8ee0f..811fc7f7e91fe2c933cfb82b651041e0faceeba2 100644
--- a/bench/nanobench.cpp
+++ b/bench/nanobench.cpp
@@ -532,12 +532,8 @@ int nanobench_main() {
#if SK_DEBUG
// skia:2797 Some SKPs SkASSERT in debug mode. Skip them for now.
- if (0 == strcmp("565", config)
- && ( SkStrStartsWith(bench->getName(), "desk_carsvg.skp")
- || SkStrStartsWith(bench->getName(), "desk_forecastio.skp")
- || SkStrStartsWith(bench->getName(), "tabl_cnet.skp")
- || SkStrStartsWith(bench->getName(), "tabl_googlecalendar.skp"))) {
- SkDebugf("Skipping 565 %s. It'd assert.\n", bench->getName());
+ if (0 == strcmp("565", config) && SkStrContains(bench->getName(), ".skp")) {
+ SkDebugf("Skipping 565 %s. See skia:2797\n", bench->getName());
continue;
}
#endif
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698