Source/core/editing/FrameSelection.h - Issue 431983005: FrameSelection::updateApperance for caret should not cause layout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/FrameSelection.h

Issue 431983005: FrameSelection::updateApperance for caret should not cause layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add updateLocalCaretRect function Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/FrameSelection.h

diff --git a/Source/core/editing/FrameSelection.h b/Source/core/editing/FrameSelection.h

index ebffebe35f6ffa60f3aa7b1f63c8f5b722ede3d2..c3c8234fa7f1480266f9b83f352d2bdffad0ecdc 100644

--- a/Source/core/editing/FrameSelection.h

+++ b/Source/core/editing/FrameSelection.h

@@ -139,8 +139,8 @@ public:

// Return the renderer that is responsible for painting the caret (in the selection start node)

RenderBlock* caretRenderer() const;

- // Caret rect local to the caret's renderer

- LayoutRect localCaretRect();

+ // Update caret rect local to the caret's renderer

+ void updateLocalCaretRect();

LayoutRect localCaretRectWithoutUpdateForTesting() const { return CaretBase::localCaretRectWithoutUpdate(); }

// Bounds of (possibly transformed) caret in absolute coords

« no previous file with comments | « no previous file | Source/core/editing/FrameSelection.cpp » ('j') | Source/core/editing/FrameSelection.cpp » ('J')