Source/core/editing/Caret.cpp - Issue 431983005: FrameSelection::updateApperance for caret should not cause layout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/Caret.cpp

Issue 431983005: FrameSelection::updateApperance for caret should not cause layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix test failures Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/repaint/paint-caret-in-div-with-negative-indent-expected.txt ('k') | Source/core/editing/FrameSelection.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/Caret.cpp

diff --git a/Source/core/editing/Caret.cpp b/Source/core/editing/Caret.cpp

index 4b8ae4aa90f15136e1eb283945b84ae0b462d57b..06424f29cea82ea09e9d712c7592ef1c9382e5df 100644

--- a/Source/core/editing/Caret.cpp

+++ b/Source/core/editing/Caret.cpp

@@ -70,10 +70,12 @@ void DragCaretController::setCaretPosition(const VisiblePosition& position)

invalidateCaretRect(node);

document = &node->document();

}

- if (m_position.isNull() || m_position.isOrphan())

+ if (m_position.isNull() || m_position.isOrphan()) {

clearCaretRect();

- else

+ } else {

+ document->updateRenderTreeIfNeeded();

updateCaretRect(document, m_position);

+ }

}

static bool removingNodeRemovesPosition(Node& node, const Position& position)

@@ -134,7 +136,6 @@ RenderBlock* CaretBase::caretRenderer(Node* node)

bool CaretBase::updateCaretRect(Document* document, const PositionWithAffinity& caretPosition)

{

- document->updateRenderTreeIfNeeded();

m_caretLocalRect = LayoutRect();

m_caretRectNeedsUpdate = false;