Source/core/editing/FrameSelection.h - Issue 431983005: FrameSelection::updateApperance for caret should not cause layout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/FrameSelection.h

Issue 431983005: FrameSelection::updateApperance for caret should not cause layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Delay invalidation Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/platform/win/fast/repaint/selection-after-delete-expected.txt ('k') | Source/core/editing/FrameSelection.cpp » ('j') | Source/core/frame/FrameView.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/FrameSelection.h

diff --git a/Source/core/editing/FrameSelection.h b/Source/core/editing/FrameSelection.h

index ebffebe35f6ffa60f3aa7b1f63c8f5b722ede3d2..52ba44739b51c5ef3256b9f065a27f770dbcfef0 100644

--- a/Source/core/editing/FrameSelection.h

+++ b/Source/core/editing/FrameSelection.h

@@ -89,6 +89,10 @@ public:

NonDirectional,

Directional

};

+ enum UpdateAppearanceOption {

+ None,

+ ResetCaretBlink

+ };

Element* rootEditableElement() const { return m_selection.rootEditableElement(); }

Element* rootEditableElementOrDocumentElement() const;

@@ -184,7 +188,7 @@ public:

void pageActivationChanged();

// Painting.

- void updateAppearance();

+ void updateAppearance(UpdateAppearanceOption = None);

void updateSecureKeyboardEntryIfActive();