Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: Source/core/editing/FrameSelection.h

Issue 431983005: FrameSelection::updateApperance for caret should not cause layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix a repaint expectation Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/editing/FrameSelection.h
diff --git a/Source/core/editing/FrameSelection.h b/Source/core/editing/FrameSelection.h
index ebffebe35f6ffa60f3aa7b1f63c8f5b722ede3d2..b900d71d655bbccaf69b01603f9002365acae8e0 100644
--- a/Source/core/editing/FrameSelection.h
+++ b/Source/core/editing/FrameSelection.h
@@ -89,6 +89,10 @@ public:
NonDirectional,
Directional
};
+ enum UpdateAppearanceOption {
+ None,
+ ResetCaretBlink
+ };
Element* rootEditableElement() const { return m_selection.rootEditableElement(); }
Element* rootEditableElementOrDocumentElement() const;
@@ -139,8 +143,8 @@ public:
// Return the renderer that is responsible for painting the caret (in the selection start node)
RenderBlock* caretRenderer() const;
- // Caret rect local to the caret's renderer
- LayoutRect localCaretRect();
+ // Update caret rect local to the caret's renderer
+ void updateLocalCaretRect();
LayoutRect localCaretRectWithoutUpdateForTesting() const { return CaretBase::localCaretRectWithoutUpdate(); }
// Bounds of (possibly transformed) caret in absolute coords
@@ -184,7 +188,7 @@ public:
void pageActivationChanged();
// Painting.
- void updateAppearance();
+ void updateAppearance(UpdateAppearanceOption = None);
void updateSecureKeyboardEntryIfActive();

Powered by Google App Engine
This is Rietveld 408576698