Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Side by Side Diff: Source/core/frame/FrameView.cpp

Issue 431983005: FrameSelection::updateApperance for caret should not cause layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix test failures Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 977 matching lines...) Expand 10 before | Expand all | Expand 10 after
988 if (hasVerticalBarDamage()) 988 if (hasVerticalBarDamage())
989 invalidateRect(verticalBarDamage()); 989 invalidateRect(verticalBarDamage());
990 if (hasHorizontalBarDamage()) 990 if (hasHorizontalBarDamage())
991 invalidateRect(horizontalBarDamage()); 991 invalidateRect(horizontalBarDamage());
992 resetScrollbarDamage(); 992 resetScrollbarDamage();
993 993
994 m_doFullPaintInvalidation = false; 994 m_doFullPaintInvalidation = false;
995 #ifndef NDEBUG 995 #ifndef NDEBUG
996 renderView()->assertSubtreeClearedPaintInvalidationState(); 996 renderView()->assertSubtreeClearedPaintInvalidationState();
997 #endif 997 #endif
998
999 if (m_frame->selection().isCaretBoundsDirty())
1000 m_frame->selection().invalidateCaretRect();
998 } 1001 }
999 1002
1000 DocumentLifecycle& FrameView::lifecycle() const 1003 DocumentLifecycle& FrameView::lifecycle() const
1001 { 1004 {
1002 return m_frame->document()->lifecycle(); 1005 return m_frame->document()->lifecycle();
1003 } 1006 }
1004 1007
1005 void FrameView::gatherDebugLayoutRects(RenderObject* layoutRoot) 1008 void FrameView::gatherDebugLayoutRects(RenderObject* layoutRoot)
1006 { 1009 {
1007 bool isTracing; 1010 bool isTracing;
(...skipping 2124 matching lines...) Expand 10 before | Expand all | Expand 10 after
3132 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation) 3135 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation)
3133 { 3136 {
3134 ScrollableArea::willRemoveScrollbar(scrollbar, orientation); 3137 ScrollableArea::willRemoveScrollbar(scrollbar, orientation);
3135 if (AXObjectCache* cache = axObjectCache()) { 3138 if (AXObjectCache* cache = axObjectCache()) {
3136 cache->remove(scrollbar); 3139 cache->remove(scrollbar);
3137 cache->handleScrollbarUpdate(this); 3140 cache->handleScrollbarUpdate(this);
3138 } 3141 }
3139 } 3142 }
3140 3143
3141 } // namespace blink 3144 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/editing/FrameSelection.cpp ('k') | Source/core/html/HTMLTextFormControlElementTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698