Fix flakiness of DesktopDragDropClientAuraX11Tests

ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_WIDGET_DESKTOP_AURA_DESKTOP_DRAG_DROP_CLIENT_AURAX11_H_
 #define UI_VIEWS_WIDGET_DESKTOP_AURA_DESKTOP_DRAG_DROP_CLIENT_AURAX11_H_
 
 #include <set>
 #include <X11/Xlib.h>
 
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/timer/timer.h"
 #include "ui/aura/window_observer.h"
 #include "ui/base/cursor/cursor.h"
 #include "ui/base/dragdrop/drag_drop_types.h"
 #include "ui/gfx/point.h"
 #include "ui/gfx/x/x11_atom_cache.h"
 #include "ui/views/views_export.h"
-#include "ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h"
-#include "ui/views/widget/desktop_aura/x11_whole_screen_move_loop_delegate.h"
+#include "ui/views/widget/desktop_aura/x11_move_loop_delegate.h"
 #include "ui/wm/public/drag_drop_client.h"
 
 namespace aura {
 namespace client {
 class DragDropDelegate;
 }
 }
 
 namespace gfx {
 class Point;
 }
 
 namespace ui {
 class DragSource;
 class DropTargetEvent;
 class OSExchangeData;
 class OSExchangeDataProviderAuraX11;
 class SelectionFormatMap;
 }
 
 namespace views {
 class DesktopNativeCursorManager;
+class X11MoveLoop;
 
 // Implements drag and drop on X11 for aura. On one side, this class takes raw
 // X11 events forwarded from DesktopWindowTreeHostLinux, while on the other, it
 // handles the views drag events.
 class VIEWS_EXPORT DesktopDragDropClientAuraX11
     : public aura::client::DragDropClient,
       public aura::WindowObserver,
-      public X11WholeScreenMoveLoopDelegate {
+      public X11MoveLoopDelegate {
  public:
   DesktopDragDropClientAuraX11(
       aura::Window* root_window,
       views::DesktopNativeCursorManager* cursor_manager,
       Display* xdisplay,
       ::Window xwindow);
   virtual ~DesktopDragDropClientAuraX11();
 
   // We maintain a mapping of live DesktopDragDropClientAuraX11 objects to
   // their ::Windows. We do this so that we're able to short circuit sending
   // X11 messages to windows in our process.
   static DesktopDragDropClientAuraX11* GetForWindow(::Window window);
 
+  void Init();
+
   // These methods handle the various X11 client messages from the platform.
   void OnXdndEnter(const XClientMessageEvent& event);
   void OnXdndLeave(const XClientMessageEvent& event);
   void OnXdndPosition(const XClientMessageEvent& event);
   void OnXdndStatus(const XClientMessageEvent& event);
   void OnXdndFinished(const XClientMessageEvent& event);
   void OnXdndDrop(const XClientMessageEvent& event);
 
   // Called when XSelection data has been copied to our process.
   void OnSelectionNotify(const XSelectionEvent& xselection);
@@ skipping 17 matching lines @@
   virtual void OnWindowDestroyed(aura::Window* window) OVERRIDE;
 
   // Overridden from X11WholeScreenMoveLoopDelegate:
   virtual void OnMouseMovement(XMotionEvent* event) OVERRIDE;
   virtual void OnMouseReleased() OVERRIDE;
   virtual void OnMoveLoopEnded() OVERRIDE;
 
  protected:
   // The following methods are virtual for the sake of testing.
 
+  // Creates a move loop.
+  virtual scoped_ptr<X11MoveLoop> CreateMoveLoop(
+      X11MoveLoopDelegate* delegate);
+
   // Finds the topmost X11 window at |screen_point| and returns it if it is
   // Xdnd aware. Returns NULL otherwise.
   virtual ::Window FindWindowFor(const gfx::Point& screen_point);
 
   // Sends |xev| to |xid|, optionally short circuiting the round trip to the X
   // server.
   virtual void SendXClientEvent(::Window xid, XEvent* xev);
 
  private:
   enum SourceState {
@@ skipping 58 matching lines @@
                             const gfx::Point& screen_point);
 
   void SendXdndEnter(::Window dest_window);
   void SendXdndLeave(::Window dest_window);
   void SendXdndPosition(::Window dest_window,
                         const gfx::Point& screen_point,
                         unsigned long event_time);
   void SendXdndDrop(::Window dest_window);
 
   // A nested message loop that notifies this object of events through the
-  // X11WholeScreenMoveLoopDelegate interface.
-  X11WholeScreenMoveLoop move_loop_;
+  // X11MoveLoopDelegate interface.
+  scoped_ptr<X11MoveLoop> move_loop_;
 
   aura::Window* root_window_;
 
   Display* xdisplay_;
   ::Window xwindow_;
 
   ui::X11AtomCache atom_cache_;
 
   // Target side information.
   class X11DragContext;
@@ skipping 60 matching lines @@
   gfx::NativeCursor move_grab_cursor_;
 
   base::WeakPtrFactory<DesktopDragDropClientAuraX11> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(DesktopDragDropClientAuraX11);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_WIDGET_DESKTOP_AURA_DESKTOP_DRAG_DROP_CLIENT_AURAX11_H_