Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 431943003: [DevTools] Whitelist default context menu options for DevTools. (Closed)

Created:
6 years, 4 months ago by dgozman
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

[DevTools] Whitelist default context menu options for DevTools. BUG=398867 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287114

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M components/renderer_context_menu/context_menu_content_type.cc View 1 4 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
dgozman
Could you please take a look?
6 years, 4 months ago (2014-07-31 12:08:40 UTC) #1
Avi (use Gerrit)
lgtm
6 years, 4 months ago (2014-07-31 12:56:02 UTC) #2
pfeldman
lgtm
6 years, 4 months ago (2014-07-31 16:22:34 UTC) #3
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 4 months ago (2014-07-31 17:30:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/431943003/1
6 years, 4 months ago (2014-07-31 17:32:27 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win8_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-07-31 21:48:04 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-31 21:51:30 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/1284)
6 years, 4 months ago (2014-07-31 21:51:30 UTC) #8
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 4 months ago (2014-08-01 10:32:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/431943003/1
6 years, 4 months ago (2014-08-01 10:35:26 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win8_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-01 14:50:34 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-01 14:53:46 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/1422)
6 years, 4 months ago (2014-08-01 14:53:47 UTC) #13
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 4 months ago (2014-08-01 16:48:13 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/431943003/20001
6 years, 4 months ago (2014-08-01 16:51:00 UTC) #15
commit-bot: I haz the power
6 years, 4 months ago (2014-08-01 23:09:28 UTC) #16
Message was sent while issue was closed. 
Change committed as 287114

Powered by Google App Engine
This is Rietveld 408576698