Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 431893004: Use the display name on ChromeOS instead of the profile name. (Closed)

Created:
6 years, 4 months ago by Adrian Kuegel
Modified:
6 years, 4 months ago
CC:
chromium-reviews, pam+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Use the display name on ChromeOS instead of the profile name. Add a method to determine the name of a supervised user. So far, we used the profile name, but this doesn't work on ChromeOS. BUG=399320 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287309

Patch Set 1 #

Total comments: 2

Patch Set 2 : Improve comment and fix compile error. #

Patch Set 3 : Fix the failing unit tests. #

Total comments: 2

Patch Set 4 : Address nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M chrome/browser/supervised_user/supervised_user_service.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.cc View 1 2 3 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
Adrian Kuegel
Hi Bernhard, hi Nikita, can you please review this CL?
6 years, 4 months ago (2014-07-31 16:26:44 UTC) #1
Bernhard Bauer
LGTM https://codereview.chromium.org/431893004/diff/1/chrome/browser/supervised_user/supervised_user_service.h File chrome/browser/supervised_user/supervised_user_service.h (right): https://codereview.chromium.org/431893004/diff/1/chrome/browser/supervised_user/supervised_user_service.h#newcode118 chrome/browser/supervised_user/supervised_user_service.h:118: // user. I would just say "human-readable name" ...
6 years, 4 months ago (2014-07-31 16:40:44 UTC) #2
Adrian Kuegel
https://codereview.chromium.org/431893004/diff/1/chrome/browser/supervised_user/supervised_user_service.h File chrome/browser/supervised_user/supervised_user_service.h (right): https://codereview.chromium.org/431893004/diff/1/chrome/browser/supervised_user/supervised_user_service.h#newcode118 chrome/browser/supervised_user/supervised_user_service.h:118: // user. On 2014/07/31 16:40:44, Bernhard Bauer wrote: > ...
6 years, 4 months ago (2014-07-31 17:02:50 UTC) #3
Nikita (slow)
lgtm
6 years, 4 months ago (2014-07-31 17:10:15 UTC) #4
Adrian Kuegel
The CQ bit was checked by akuegel@chromium.org
6 years, 4 months ago (2014-08-01 08:55:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akuegel@chromium.org/431893004/80001
6 years, 4 months ago (2014-08-01 08:56:53 UTC) #6
Adrian Kuegel
There were some issues with failing unit tests. I changed the code to check if ...
6 years, 4 months ago (2014-08-01 11:10:07 UTC) #7
Nikita (slow)
lgtm https://codereview.chromium.org/431893004/diff/100001/chrome/browser/supervised_user/supervised_user_service.cc File chrome/browser/supervised_user/supervised_user_service.cc (right): https://codereview.chromium.org/431893004/diff/100001/chrome/browser/supervised_user/supervised_user_service.cc#newcode775 chrome/browser/supervised_user/supervised_user_service.cc:775: return ""; nit: std::string()
6 years, 4 months ago (2014-08-01 11:27:17 UTC) #8
Adrian Kuegel
https://codereview.chromium.org/431893004/diff/100001/chrome/browser/supervised_user/supervised_user_service.cc File chrome/browser/supervised_user/supervised_user_service.cc (right): https://codereview.chromium.org/431893004/diff/100001/chrome/browser/supervised_user/supervised_user_service.cc#newcode775 chrome/browser/supervised_user/supervised_user_service.cc:775: return ""; On 2014/08/01 11:27:17, Nikita Kostylev wrote: > ...
6 years, 4 months ago (2014-08-01 11:43:01 UTC) #9
Adrian Kuegel
The CQ bit was checked by akuegel@chromium.org
6 years, 4 months ago (2014-08-01 11:43:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akuegel@chromium.org/431893004/120001
6 years, 4 months ago (2014-08-01 11:44:46 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-01 19:28:19 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-01 22:38:14 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/builds/2459)
6 years, 4 months ago (2014-08-01 22:38:15 UTC) #14
Adrian Kuegel
The CQ bit was checked by akuegel@chromium.org
6 years, 4 months ago (2014-08-04 07:28:06 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akuegel@chromium.org/431893004/120001
6 years, 4 months ago (2014-08-04 07:28:42 UTC) #16
commit-bot: I haz the power
6 years, 4 months ago (2014-08-04 09:46:42 UTC) #17
Message was sent while issue was closed. 
Change committed as 287309

Powered by Google App Engine
This is Rietveld 408576698