Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 431833002: Cleanup: Only define various NaCl flags when PPAPI is enabled. (Closed)

Created:
6 years, 4 months ago by Lei Zhang
Modified:
6 years, 4 months ago
Reviewers:
victorhsieh
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Cleanup: Only define various NaCl flags when PPAPI is enabled. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287406

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M chrome/browser/about_flags.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/chrome_switches.h View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Lei Zhang
6 years, 4 months ago (2014-07-31 00:21:32 UTC) #1
victorhsieh
lgtm LGTM, though you'd need owners to approve
6 years, 4 months ago (2014-07-31 16:54:18 UTC) #2
Lei Zhang
On 2014/07/31 16:54:18, victorhsieh wrote: > lgtm > > LGTM, though you'd need owners to ...
6 years, 4 months ago (2014-07-31 19:03:02 UTC) #3
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-07-31 19:03:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/431833002/1
6 years, 4 months ago (2014-07-31 19:03:59 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-31 23:13:25 UTC) #6
Lei Zhang
The CQ bit was unchecked by thestig@chromium.org
6 years, 4 months ago (2014-07-31 23:15:18 UTC) #7
Lei Zhang
Bleh, why are we building ppapi_tests.cc on Android? I'll first have to fix that: https://codereview.chromium.org/435603006/
6 years, 4 months ago (2014-08-01 01:16:46 UTC) #8
Lei Zhang
On 2014/08/01 01:16:46, Lei Zhang wrote: > Bleh, why are we building ppapi_tests.cc on Android? ...
6 years, 4 months ago (2014-08-04 18:57:49 UTC) #9
Lei Zhang
On 2014/08/04 18:57:49, Lei Zhang wrote: > The other CL as landed, so this one ...
6 years, 4 months ago (2014-08-04 18:58:01 UTC) #10
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-04 18:58:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/431833002/20001
6 years, 4 months ago (2014-08-04 18:58:34 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 00:00:47 UTC) #13
Message was sent while issue was closed.
Change committed as 287406

Powered by Google App Engine
This is Rietveld 408576698