Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 431693002: Reland "ui/aura: Enable the build of demo, bench and unit..." (Closed)

Created:
6 years, 4 months ago by tfarina
Modified:
6 years, 4 months ago
CC:
chromium-reviews, sadrul, tdresser+watch_chromium.org, ben+aura_chromium.org, kalyank
Project:
chromium
Visibility:
Public.

Description

Reland "ui/aura: Enable the build of demo, bench and unit..." This was originally landed in r286542 and reverted at r286557. BUG=None TEST=gn gen out/Debug_gn && ninja -C out/Debug_gn ui/aura:demo ui/aura:bench ui/aura:unittests R=brettw@chromium.org,ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286619

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -96 lines) Patch
M ui/aura/BUILD.gn View 1 chunk +90 lines, -96 lines 0 comments Download
M ui/events/BUILD.gn View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
6 years, 4 months ago (2014-07-30 18:59:12 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 4 months ago (2014-07-30 20:20:07 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 4 months ago (2014-07-30 20:24:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/431693002/1
6 years, 4 months ago (2014-07-30 21:00:01 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 22:32:57 UTC) #5
Message was sent while issue was closed.
Change committed as 286619

Powered by Google App Engine
This is Rietveld 408576698