Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 431663002: Disable certain malloc-library tests for OSX 10.9 32-bit. (Closed)

Created:
6 years, 4 months ago by Scott Hess - ex-Googler
Modified:
6 years, 4 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Disable certain malloc-library tests for OSX 10.9 32-bit. Chromium's code to enable malloc corruption detection, out-of-memory termination, and UncheckedMalloc/Calloc under older versions of the OSX malloc library stopped working under OSX 10.9 (Mavericks). The 64-bit malloc library handles corruption detection the way Chromium prefers by default, allowing everything to work correctly. Short-circuit the tests which cannot be fixed for the intersection of 32-bit and OSX >= 10.9. BUG=383082 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286917

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M base/process/memory_unittest.cc View 4 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Scott Hess - ex-Googler
I did not implement any sort of milestone check to force revisiting this later, because ...
6 years, 4 months ago (2014-07-30 16:28:05 UTC) #1
Mark Mentovai
LGTM. This is fine.
6 years, 4 months ago (2014-07-30 17:36:58 UTC) #2
Scott Hess - ex-Googler
The CQ bit was checked by shess@chromium.org
6 years, 4 months ago (2014-07-30 17:53:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/431663002/1
6 years, 4 months ago (2014-07-30 17:54:40 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-30 19:30:17 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-30 19:55:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/1487)
6 years, 4 months ago (2014-07-30 19:55:07 UTC) #7
Scott Hess - ex-Googler
The CQ bit was checked by shess@chromium.org
6 years, 4 months ago (2014-07-31 19:34:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/431663002/1
6 years, 4 months ago (2014-07-31 19:36:40 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-07-31 23:57:05 UTC) #10
Message was sent while issue was closed.
Change committed as 286917

Powered by Google App Engine
This is Rietveld 408576698