Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 431613003: fix missing return in error case for bitmap scaler (Closed)

Created:
6 years, 4 months ago by humper
Modified:
6 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

fix missing return in error case for bitmap scaler BUG=skia: Committed: https://skia.googlesource.com/skia/+/e86af3738abdfb5ba230101470b94189bb2e98b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/core/SkBitmapScaler.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
humper
Noticed this oversight while fixing a merge -- ptal.
6 years, 4 months ago (2014-07-30 14:51:06 UTC) #1
bsalomon
lgtm
6 years, 4 months ago (2014-07-30 14:57:04 UTC) #2
humper
The CQ bit was checked by humper@google.com
6 years, 4 months ago (2014-08-04 13:23:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/431613003/1
6 years, 4 months ago (2014-08-04 13:23:55 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot on tryserver.skia ...
6 years, 4 months ago (2014-08-04 14:52:52 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-04 15:31:37 UTC) #6
Message was sent while issue was closed.
Change committed as e86af3738abdfb5ba230101470b94189bb2e98b1

Powered by Google App Engine
This is Rietveld 408576698