Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 431603002: Fix ref counting of cached layer's texture (Closed)

Created:
6 years, 4 months ago by robertphillips
Modified:
6 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix ref counting of cached layer's texture Committed: https://skia.googlesource.com/skia/+/ed6f03e5edea3fb803ac937184796a5bef65cd9b

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove incorrect comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M src/gpu/GrLayerCache.h View 1 1 chunk +5 lines, -6 lines 0 comments Download
M src/gpu/GrLayerCache.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
robertphillips
6 years, 4 months ago (2014-07-30 13:59:48 UTC) #1
bsalomon
lgtm w/ q about comment. https://codereview.chromium.org/431603002/diff/1/src/gpu/GrLayerCache.h File src/gpu/GrLayerCache.h (right): https://codereview.chromium.org/431603002/diff/1/src/gpu/GrLayerCache.h#newcode92 src/gpu/GrLayerCache.h:92: // This call takes ...
6 years, 4 months ago (2014-07-30 14:10:38 UTC) #2
robertphillips
https://codereview.chromium.org/431603002/diff/1/src/gpu/GrLayerCache.h File src/gpu/GrLayerCache.h (right): https://codereview.chromium.org/431603002/diff/1/src/gpu/GrLayerCache.h#newcode92 src/gpu/GrLayerCache.h:92: // This call takes over the caller's ref On ...
6 years, 4 months ago (2014-07-30 14:19:10 UTC) #3
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 4 months ago (2014-07-30 14:19:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/431603002/20001
6 years, 4 months ago (2014-07-30 14:19:38 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 14:31:40 UTC) #6
Message was sent while issue was closed.
Change committed as ed6f03e5edea3fb803ac937184796a5bef65cd9b

Powered by Google App Engine
This is Rietveld 408576698