Issue 431503004: Fix calibration loop failure condition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 431503004: Fix calibration loop failure condition. (Closed)

Created:
6 years, 4 months ago by mtklein_C

Modified:
6 years, 4 months ago

Reviewers:
djsollen, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Fix calibration loop failure condition. With the old logic, if the last attempt succeeded, we'd say we failed. We also print two lines for loop calibration failures. Quiet that down. BUG=skia: Committed: https://skia.googlesource.com/skia/+/2069e220034f09aad2f68b262f395e7c25b3d178

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -7 lines)			Patch
	M	bench/nanobench.cpp	View		2 chunks	+6 lines, -7 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/431503004/1

6 years, 4 months ago (2014-08-04 20:47:48 UTC) #4

commit-bot: I haz the power

6 years, 4 months ago (2014-08-04 20:57:46 UTC) #5

Message was sent while issue was closed.

Change committed as 2069e220034f09aad2f68b262f395e7c25b3d178