Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Unified Diff: chrome/renderer/resources/extensions/extension_options_events.js

Issue 431503002: Implement autosizing for <extensionoptions> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add tests and ensure that size constraints make sense Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/extension_options_events.js
diff --git a/chrome/renderer/resources/extensions/extension_options_events.js b/chrome/renderer/resources/extensions/extension_options_events.js
index a93f05ca5edf12d76cf5a9dbe9c0c59c40de46b5..c842b08ed62b9b1780c5d97550454bfdf1c8791a 100644
--- a/chrome/renderer/resources/extensions/extension_options_events.js
+++ b/chrome/renderer/resources/extensions/extension_options_events.js
@@ -14,6 +14,13 @@ var EXTENSION_OPTIONS_EVENTS = {
evt: CreateEvent('extensionOptionsInternal.onLoad'),
fields: []
},
+ 'sizechanged': {
+ evt: CreateEvent('extensionOptionsInternal.onSizeChanged'),
+ customHandler: function(handler, event, webViewEvent) {
+ handler.handleSizeChangedEvent(event, webViewEvent);
+ },
+ fields:['width', 'height']
+ }
}
/**
@@ -54,5 +61,12 @@ ExtensionOptionsEvents.prototype.setupEvent = function(name, info) {
this.extensionOptionsInternal.setupEventProperty(name);
};
+ExtensionOptionsEvents.prototype.handleSizeChangedEvent = function(
+ event, extensionOptionsEvent) {
+ this.extensionOptionsInternal.onSizeChanged(extensionOptionsEvent.width,
+ extensionOptionsEvent.height);
+ this.extensionOptionsInternal.dispatchEvent(extensionOptionsEvent);
+}
+
exports.ExtensionOptionsEvents = ExtensionOptionsEvents;
exports.CreateEvent = CreateEvent;

Powered by Google App Engine
This is Rietveld 408576698