chrome/browser/guest_view/extension_options/extension_options_guest.h - Issue 431503002: Implement autosizing for <extensionoptions>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/extension_options/extension_options_guest.h

Issue 431503002: Implement autosizing for <extensionoptions> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add tests and ensure that size constraints make sense Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/guest_view/extension_options/extension_options_constants.cc ('k') | chrome/browser/guest_view/extension_options/extension_options_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/extension_options/extension_options_guest.h

diff --git a/chrome/browser/guest_view/extension_options/extension_options_guest.h b/chrome/browser/guest_view/extension_options/extension_options_guest.h

index eaee7520f88e2b83d5820590ecc48f06d566f9b4..6373ae5ba3cce8234dcb67a8d7496d0907b815f9 100644

--- a/chrome/browser/guest_view/extension_options/extension_options_guest.h

+++ b/chrome/browser/guest_view/extension_options/extension_options_guest.h

@@ -33,6 +33,10 @@ class ExtensionOptionsGuest

virtual void DidAttachToEmbedder() OVERRIDE;

virtual void DidInitialize() OVERRIDE;

virtual void DidStopLoading() OVERRIDE;

+ virtual void GuestSizeChangedDueToAutoSize(

+ const gfx::Size& old_size,

+ const gfx::Size& new_size) OVERRIDE;

+ virtual bool IsAutoSizeSupported() const OVERRIDE;

// ExtensionFunctionDispatcher::Delegate implementation.

virtual content::WebContents* GetAssociatedWebContents() const OVERRIDE;

@@ -44,6 +48,7 @@ class ExtensionOptionsGuest

ExtensionOptionsGuest(content::BrowserContext* browser_context,

int guest_instance_id);

virtual ~ExtensionOptionsGuest();

+ void SetUpAutoSize();

void OnRequest(const ExtensionHostMsg_Request_Params& params);

scoped_ptr<extensions::ExtensionFunctionDispatcher>